You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2025/01/14 17:34:54 UTC
[PR] [MNG-8520] Add cache for model resolution during project building [maven]
gnodet opened a new pull request, #2047:
URL: https://github.com/apache/maven/pull/2047
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2592167603
Tested locally, commented on https://issues.apache.org/jira/browse/MNG-8520 (tl;dr: it restores previous behaviour, excess of events are gone)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2593402430
And from where you get the nightly build? You are building it yourselves?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2592170647
@alextu Can you confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #2047:
URL: https://github.com/apache/maven/pull/2047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "alextu (via GitHub)" <gi...@apache.org>.
alextu commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2593386653
> @alextu Can you confirm?
It looks like it's better, using the reproducer I sent. I'll be able to confirm once it's merged as our test suite runs with our own nightly built from Maven master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "alextu (via GitHub)" <gi...@apache.org>.
alextu commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2596312005
> "additional requests that are not traced back to plugins" -- isnt this the https://issues.apache.org/jira/browse/MNG-8519 ? Or "additional" as "count of them is still more than was in mvn3"?
The count of them is more, for example, in this test, we see 153 requests with this Maven 4 version and 117 with Maven 3.9.9. We count a request when we receive a pair of `RepositoryEvent` objects with type `ARTIFACT_DOWNLOADING` (or `METADATA_DOWNLOADING`) and `ARTIFACT_DOWNLOADED` (or `METADATA_DOWNLOADED`).
As part of this test, we also see that some (all?) of those additional requests cannot be traced back to a plugin or a project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "alextu (via GitHub)" <gi...@apache.org>.
alextu commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2593431232
> And from where you get the nightly build? You are building it yourselves?
yes on our internal CI. If really needed, I can check tomorrow how to tweak that to build a custom branch instead of master and use that in our tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "alextu (via GitHub)" <gi...@apache.org>.
alextu commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2596046392
I've built this branch:
```
mvn --version
Apache Maven 4.0.0-rc-3-SNAPSHOT (129afd91931d6cb8688ab6f03d82c43e6ceb0815)
```
and run our tests, they're still failing for the same reason(s) 🤔: additional requests that are not traced back to plugins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MNG-8520] Add cache for model resolution during project building [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #2047:
URL: https://github.com/apache/maven/pull/2047#issuecomment-2596132573
"additional requests that are not traced back to plugins" -- isnt this the https://issues.apache.org/jira/browse/MNG-8519 ? Or "additional" as "count of them is still more"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org