You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2024/10/31 07:58:36 UTC

svn commit: r1921703 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java

Author: tilman
Date: Thu Oct 31 07:58:36 2024
New Revision: 1921703

URL: http://svn.apache.org/viewvc?rev=1921703&view=rev
Log:
PDFBOX-5894: don't close prematurely, as suggested by Derek Wickern

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java?rev=1921703&r1=1921702&r2=1921703&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java Thu Oct 31 07:58:36 2024
@@ -73,11 +73,19 @@ public class Loader
      */
     public static FDFDocument loadFDF(File file) throws IOException
     {
-        try (RandomAccessRead readBuffer = new RandomAccessReadBufferedFile(file))
+        RandomAccessRead raFile = null;
+        try
         {
-            FDFParser parser = new FDFParser(readBuffer);
+            // PDFBOX-5894: RandomAccessRead is not closed here
+            raFile = new RandomAccessReadBufferedFile(file);
+            FDFParser parser = new FDFParser(raFile);
             return parser.parse();
         }
+        catch (IOException ioe)
+        {
+            IOUtils.closeQuietly(raFile);
+            throw ioe;
+        }
     }
 
     /**