You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/05 13:02:32 UTC
[GitHub] [mynewt-newt] utzig commented on a change in pull request #382: Fix
skipping the copy of empty dirs on tree copies
utzig commented on a change in pull request #382: Fix skipping the copy of empty dirs on tree copies
URL: https://github.com/apache/mynewt-newt/pull/382#discussion_r388278583
##########
File path: util/util.go
##########
@@ -525,7 +525,7 @@ func CopyDir(srcDirStr, dstDirStr string) error {
return ChildNewtError(err)
}
- if err := os.MkdirAll(filepath.Dir(dstDirStr), info.Mode()); err != nil {
+ if err := os.MkdirAll(dstDirStr, info.Mode()); err != nil {
Review comment:
Or maybe this should be `filepath.Clean(dstDirStr)` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services