You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/23 12:32:33 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #12196: fix(reports): make name unique between alerts and reports

dpgaspar opened a new pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196


   ### SUMMARY
   Uniqueness was being imposed on Alerts/Report names, preventing user's from create an Alert name "X" and a Report with the same name "X". This allows this while still enforcing name uniqueness on Alerts and Reports separately
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#discussion_r548428110



##########
File path: superset/migrations/versions/c878781977c6_alert_reports_shared_uniqueness.py
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""alert reports shared uniqueness
+
+Revision ID: c878781977c6
+Revises: 73fd22e742ab
+Create Date: 2020-12-23 11:34:53.882200
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "c878781977c6"
+down_revision = "73fd22e742ab"
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.dialects.mysql.base import MySQLDialect
+from sqlalchemy.dialects.postgresql.base import PGDialect
+from sqlalchemy.dialects.sqlite.base import SQLiteDialect
+from sqlalchemy.engine.reflection import Inspector
+
+from superset.utils.core import generic_find_uq_constraint_name
+
+report_schedule = sa.Table(
+    "report_schedule",
+    sa.MetaData(),
+    sa.Column("id", sa.Integer(), nullable=False),
+    sa.Column("type", sa.String(length=50), nullable=False),
+    sa.Column("name", sa.String(length=150), nullable=False),
+    sa.Column("description", sa.Text(), nullable=True),
+    sa.Column("context_markdown", sa.Text(), nullable=True),
+    sa.Column("active", sa.Boolean(), default=True, nullable=True),
+    sa.Column("crontab", sa.String(length=1000), nullable=False),
+    sa.Column("sql", sa.Text(), nullable=True),
+    sa.Column("chart_id", sa.Integer(), nullable=True),
+    sa.Column("dashboard_id", sa.Integer(), nullable=True),
+    sa.Column("database_id", sa.Integer(), nullable=True),
+    sa.Column("last_eval_dttm", sa.DateTime(), nullable=True),
+    sa.Column("last_state", sa.String(length=50), nullable=True),
+    sa.Column("last_value", sa.Float(), nullable=True),
+    sa.Column("last_value_row_json", sa.Text(), nullable=True),
+    sa.Column("validator_type", sa.String(length=100), nullable=True),
+    sa.Column("validator_config_json", sa.Text(), default="{}", nullable=True),
+    sa.Column("log_retention", sa.Integer(), nullable=True, default=90),
+    sa.Column("grace_period", sa.Integer(), nullable=True, default=60 * 60 * 4),
+    sa.Column("working_timeout", sa.Integer(), nullable=True, default=60 * 60 * 1),
+    # Audit Mixin
+    sa.Column("created_on", sa.DateTime(), nullable=True),
+    sa.Column("changed_on", sa.DateTime(), nullable=True),
+    sa.Column("created_by_fk", sa.Integer(), nullable=True),
+    sa.Column("changed_by_fk", sa.Integer(), nullable=True),
+    sa.ForeignKeyConstraint(["chart_id"], ["slices.id"]),
+    sa.ForeignKeyConstraint(["dashboard_id"], ["dashboards.id"]),
+    sa.ForeignKeyConstraint(["database_id"], ["dbs.id"]),
+    sa.ForeignKeyConstraint(["changed_by_fk"], ["ab_user.id"]),
+    sa.ForeignKeyConstraint(["created_by_fk"], ["ab_user.id"]),
+    sa.PrimaryKeyConstraint("id"),
+)
+
+
+def upgrade():
+    bind = op.get_bind()
+
+    if not isinstance(bind.dialect, SQLiteDialect):
+        op.drop_constraint("uq_report_schedule_name", "report_schedule", type_="unique")
+
+        if isinstance(bind.dialect, MySQLDialect):
+            op.drop_index(
+                op.f("name"), table_name="report_schedule",
+            )
+
+        if isinstance(bind.dialect, PGDialect):
+            op.drop_constraint(
+                "report_schedule_name_key", "report_schedule", type_="unique"
+            )
+        op.create_unique_constraint(
+            "uq_report_schedule_name_type", "report_schedule", ["name", "type"]
+        )
+
+    else:
+        with op.batch_alter_table(
+            "report_schedule", copy_from=report_schedule
+        ) as batch_op:
+            batch_op.create_unique_constraint(
+                "uq_report_schedule_name_type", ["name", "type"]
+            )

Review comment:
       This took a loong while for me to wrap my head around 😆 A small comment here could be really helpful for the next person trying to understand what's going on.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#discussion_r548084026



##########
File path: superset/migrations/versions/c878781977c6_alert_reports_shared_uniqueness.py
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""alert reports shared uniqueness
+
+Revision ID: c878781977c6
+Revises: 73fd22e742ab
+Create Date: 2020-12-23 11:34:53.882200
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "c878781977c6"
+down_revision = "73fd22e742ab"
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.dialects.mysql.base import MySQLDialect
+from sqlalchemy.dialects.postgresql.base import PGDialect
+from sqlalchemy.dialects.sqlite.base import SQLiteDialect
+from sqlalchemy.engine.reflection import Inspector
+
+from superset.utils.core import generic_find_uq_constraint_name
+
+report_schedule = sa.Table(
+    "report_schedule",
+    sa.MetaData(),
+    sa.Column("id", sa.Integer(), nullable=False),
+    sa.Column("type", sa.String(length=50), nullable=False),
+    sa.Column("name", sa.String(length=150), nullable=False),
+    sa.Column("description", sa.Text(), nullable=True),
+    sa.Column("context_markdown", sa.Text(), nullable=True),
+    sa.Column("active", sa.Boolean(), default=True, nullable=True),
+    sa.Column("crontab", sa.String(length=1000), nullable=False),
+    sa.Column("sql", sa.Text(), nullable=True),
+    sa.Column("chart_id", sa.Integer(), nullable=True),
+    sa.Column("dashboard_id", sa.Integer(), nullable=True),
+    sa.Column("database_id", sa.Integer(), nullable=True),
+    sa.Column("last_eval_dttm", sa.DateTime(), nullable=True),
+    sa.Column("last_state", sa.String(length=50), nullable=True),
+    sa.Column("last_value", sa.Float(), nullable=True),
+    sa.Column("last_value_row_json", sa.Text(), nullable=True),
+    sa.Column("validator_type", sa.String(length=100), nullable=True),
+    sa.Column("validator_config_json", sa.Text(), default="{}", nullable=True),
+    sa.Column("log_retention", sa.Integer(), nullable=True, default=90),
+    sa.Column("grace_period", sa.Integer(), nullable=True, default=60 * 60 * 4),
+    sa.Column("working_timeout", sa.Integer(), nullable=True, default=60 * 60 * 1),
+    # Audit Mixin
+    sa.Column("created_on", sa.DateTime(), nullable=True),
+    sa.Column("changed_on", sa.DateTime(), nullable=True),
+    sa.Column("created_by_fk", sa.Integer(), nullable=True),
+    sa.Column("changed_by_fk", sa.Integer(), nullable=True),
+    sa.ForeignKeyConstraint(["chart_id"], ["slices.id"]),
+    sa.ForeignKeyConstraint(["dashboard_id"], ["dashboards.id"]),
+    sa.ForeignKeyConstraint(["database_id"], ["dbs.id"]),
+    sa.ForeignKeyConstraint(["changed_by_fk"], ["ab_user.id"]),
+    sa.ForeignKeyConstraint(["created_by_fk"], ["ab_user.id"]),
+    sa.PrimaryKeyConstraint("id"),
+)
+
+
+def upgrade():
+    bind = op.get_bind()
+
+    if not isinstance(bind.dialect, SQLiteDialect):
+        op.drop_constraint("uq_report_schedule_name", "report_schedule", type_="unique")
+
+        if isinstance(bind.dialect, MySQLDialect):
+            op.drop_index(
+                op.f("name"), table_name="report_schedule",
+            )
+
+        if isinstance(bind.dialect, PGDialect):
+            op.drop_constraint(
+                "report_schedule_name_key", "report_schedule", type_="unique"
+            )
+        op.create_unique_constraint(
+            "uq_report_schedule_name_type", "report_schedule", ["name", "type"]
+        )
+
+    else:
+        with op.batch_alter_table(
+            "report_schedule", copy_from=report_schedule

Review comment:
       This was required to remove `UNIQUE (name)` that is not an actual constraint from SQLite




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#issuecomment-750392591


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=h1) Report
   > Merging [#12196](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=desc) (ead35b3) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `1.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12196/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12196      +/-   ##
   ==========================================
   - Coverage   63.06%   61.20%   -1.87%     
   ==========================================
     Files         994      510     -484     
     Lines       49075    19312   -29763     
     Branches     4984     4983       -1     
   ==========================================
   - Hits        30950    11820   -19130     
   + Misses      17925     7292   -10633     
     Partials      200      200              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `61.20% <ø> (-0.03%)` | :arrow_down: |
   | python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `50.53% <0.00%> (-1.36%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/alert/AlertList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRMaXN0LnRzeA==) | `76.74% <0.00%> (-0.36%)` | :arrow_down: |
   | [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `46.07% <0.00%> (-0.26%)` | :arrow_down: |
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.59% <0.00%> (ø)` | |
   | [...CRUD/alert/components/AlertReportCronScheduler.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvY29tcG9uZW50cy9BbGVydFJlcG9ydENyb25TY2hlZHVsZXIudHN4) | `86.95% <0.00%> (ø)` | |
   | [...tions/versions/db527d8c4c78\_add\_db\_verbose\_name.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kYjUyN2Q4YzRjNzhfYWRkX2RiX3ZlcmJvc2VfbmFtZS5weQ==) | | |
   | [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | | |
   | [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | | |
   | [...ons/versions/e96dbf2cfef0\_datasource\_cluster\_fk.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lOTZkYmYyY2ZlZjBfZGF0YXNvdXJjZV9jbHVzdGVyX2ZrLnB5) | | |
   | ... and [475 more](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=footer). Last update [93af329...ead35b3](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#issuecomment-750392591


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=h1) Report
   > Merging [#12196](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=desc) (ead35b3) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.22%`.
   > The diff coverage is `32.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12196/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12196      +/-   ##
   ==========================================
   - Coverage   63.06%   62.84%   -0.23%     
   ==========================================
     Files         994      995       +1     
     Lines       49075    49106      +31     
     Branches     4984     4983       -1     
   ==========================================
   - Hits        30950    30861      -89     
   - Misses      17925    18045     +120     
     Partials      200      200              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `61.20% <ø> (-0.03%)` | :arrow_down: |
   | python | `63.90% <32.43%> (-0.36%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ns/c878781977c6\_alert\_reports\_shared\_uniqueness.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jODc4NzgxOTc3YzZfYWxlcnRfcmVwb3J0c19zaGFyZWRfdW5pcXVlbmVzcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.55% <ø> (ø)` | |
   | [superset/reports/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy91cGRhdGUucHk=) | `89.85% <50.00%> (ø)` | |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/reports/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | `87.27% <100.00%> (ø)` | |
   | [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <100.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.59% <100.00%> (+0.10%)` | :arrow_up: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | ... and [23 more](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=footer). Last update [93af329...ead35b3](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar merged pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#issuecomment-750392591


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=h1) Report
   > Merging [#12196](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=desc) (ead35b3) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.48%`.
   > The diff coverage is `32.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12196/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12196      +/-   ##
   ==========================================
   - Coverage   63.06%   62.57%   -0.49%     
   ==========================================
     Files         994      995       +1     
     Lines       49075    49091      +16     
     Branches     4984     4983       -1     
   ==========================================
   - Hits        30950    30721     -229     
   - Misses      17925    18170     +245     
     Partials      200      200              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `61.20% <ø> (-0.03%)` | :arrow_down: |
   | python | `63.47% <32.43%> (-0.80%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ns/c878781977c6\_alert\_reports\_shared\_uniqueness.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jODc4NzgxOTc3YzZfYWxlcnRfcmVwb3J0c19zaGFyZWRfdW5pcXVlbmVzcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.55% <ø> (ø)` | |
   | [superset/reports/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy91cGRhdGUucHk=) | `89.85% <50.00%> (ø)` | |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/reports/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | `87.27% <100.00%> (ø)` | |
   | [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <100.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.59% <100.00%> (+0.10%)` | :arrow_up: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [36 more](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=footer). Last update [93af329...ead35b3](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#issuecomment-750392591


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=h1) Report
   > Merging [#12196](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=desc) (ead35b3) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.49%`.
   > The diff coverage is `32.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12196/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12196      +/-   ##
   ==========================================
   - Coverage   63.06%   62.57%   -0.50%     
   ==========================================
     Files         994      995       +1     
     Lines       49075    49106      +31     
     Branches     4984     4983       -1     
   ==========================================
   - Hits        30950    30728     -222     
   - Misses      17925    18178     +253     
     Partials      200      200              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `61.20% <ø> (-0.03%)` | :arrow_down: |
   | python | `63.46% <32.43%> (-0.80%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ns/c878781977c6\_alert\_reports\_shared\_uniqueness.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jODc4NzgxOTc3YzZfYWxlcnRfcmVwb3J0c19zaGFyZWRfdW5pcXVlbmVzcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.55% <ø> (ø)` | |
   | [superset/reports/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy91cGRhdGUucHk=) | `89.85% <50.00%> (ø)` | |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/reports/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | `87.27% <100.00%> (ø)` | |
   | [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <100.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.59% <100.00%> (+0.10%)` | :arrow_up: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | ... and [29 more](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=footer). Last update [93af329...ead35b3](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12196: fix(reports): make name unique between alerts and reports

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12196:
URL: https://github.com/apache/incubator-superset/pull/12196#issuecomment-750392591


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=h1) Report
   > Merging [#12196](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=desc) (ead35b3) into [master](https://codecov.io/gh/apache/incubator-superset/commit/93af3290787499ce9c0c2ffe931e1a7557a0b020?el=desc) (93af329) will **decrease** coverage by `0.22%`.
   > The diff coverage is `32.43%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/12196/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12196      +/-   ##
   ==========================================
   - Coverage   63.06%   62.83%   -0.23%     
   ==========================================
     Files         994      995       +1     
     Lines       49075    49106      +31     
     Branches     4984     4983       -1     
   ==========================================
   - Hits        30950    30858      -92     
   - Misses      17925    18048     +123     
     Partials      200      200              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `61.20% <ø> (-0.03%)` | :arrow_down: |
   | python | `63.89% <32.43%> (-0.37%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ns/c878781977c6\_alert\_reports\_shared\_uniqueness.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jODc4NzgxOTc3YzZfYWxlcnRfcmVwb3J0c19zaGFyZWRfdW5pcXVlbmVzcy5weQ==) | `0.00% <0.00%> (ø)` | |
   | [superset/reports/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `98.55% <ø> (ø)` | |
   | [superset/reports/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy91cGRhdGUucHk=) | `89.85% <50.00%> (ø)` | |
   | [superset/models/reports.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
   | [superset/reports/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9jcmVhdGUucHk=) | `87.27% <100.00%> (ø)` | |
   | [superset/reports/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | `79.24% <100.00%> (ø)` | |
   | [superset/reports/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9zY2hlbWFzLnB5) | `98.59% <100.00%> (+0.10%)` | :arrow_up: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | ... and [24 more](https://codecov.io/gh/apache/incubator-superset/pull/12196/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=footer). Last update [93af329...ead35b3](https://codecov.io/gh/apache/incubator-superset/pull/12196?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org