[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41528: [SPARK-43610][CONNECT][PS] Enable `InternalFrame.attach_distributed_column` in Spark Connect.

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #41528:
URL: https://github.com/apache/spark/pull/41528#discussion_r1223876210


##########
python/pyspark/pandas/internal.py:
##########
@@ -935,10 +935,11 @@ def attach_sequence_column(sdf: PySparkDataFrame, column_name: str) -> PySparkDa
         )
         return sdf.select(sequential_index.alias(column_name), *scols)
 
-    # TODO(SPARK-43610): Enable `InternalFrame.attach_distributed_column` in Spark Connect.
     @staticmethod
     def attach_distributed_column(sdf: PySparkDataFrame, column_name: str) -> PySparkDataFrame:
         scols = [scol_for(sdf, column) for column in sdf.columns]
+        if is_remote():

Review Comment:
   Can you add a comment here that we don't add an alias to avoid adding a dedicated protobuf message for cosmetic changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org