You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "RocMarshal (via GitHub)" <gi...@apache.org> on 2024/03/01 02:00:58 UTC
[PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]
RocMarshal opened a new pull request, #24417:
URL: https://github.com/apache/flink/pull/24417
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
- What is the purpose of the change
[FLINK-32570](https://issues.apache.org/jira/browse/FLINK-32570) deprecated the Time class and refactor all Public or PublicEvolving apis to use the Java's Duration.
StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time class. In general, we expect:
Mark cleanupInRocksdbCompactFilter(long, Time) as @Deprecated
Provide a new cleanupInRocksdbCompactFilter(long, Duration)
But I found this method is introduced in 1.19 ([FLINK-30854](https://issues.apache.org/jira/browse/FLINK-30854)), so a better solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration) and don't use Time.
The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I think it's better to merge this JIRA in 1.19.0 as well.
- Brief change log
[[FLINK-34522](https://issues.apache.org/jira/browse/FLINK-34522)][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter
Fix based on https://github.com/apache/flink/pull/24388 & https://github.com/apache/flink/pull/24387#issuecomment-1971427877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka merged PR #24417:
URL: https://github.com/apache/flink/pull/24417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]
Posted by "HuangXingBo (via GitHub)" <gi...@apache.org>.
HuangXingBo commented on code in PR #24417:
URL: https://github.com/apache/flink/pull/24417#discussion_r1508454782
##########
flink-python/pyflink/datastream/state.py:
##########
@@ -809,7 +809,7 @@ def cleanup_incrementally(self,
def cleanup_in_rocksdb_compact_filter(
self,
query_time_after_num_entries,
- periodic_compaction_time=Time.days(30)) -> \
+ periodic_compaction_time=Duration.of_days(30)) -> \
Review Comment:
`Duration.of_days(30)` -> None
##########
flink-python/pyflink/datastream/state.py:
##########
@@ -925,14 +926,14 @@ class RocksdbCompactFilterCleanupStrategy(CleanupStrategy):
def __init__(self,
query_time_after_num_entries: int,
- periodic_compaction_time=Time.days(30)):
+ periodic_compaction_time=Duration.of_days(30)):
Review Comment:
`Duration.of_days(30)-> None` and do the similar thing to `cleanup_in_rocksdb_compact_filter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #24417:
URL: https://github.com/apache/flink/pull/24417#issuecomment-1972847331
> Thanks for creating this PR, please correct the `import` examples in the docs.
Thanks @Myasuka for the review!
The Time is still used for ttl config and Time is not deprecated in python api in 1.19, that's why I didn't remove this import in this PR.
https://github.com/apache/flink/pull/24387#issuecomment-1966071598 also mentions this issue, FLINK-34527 will deprecate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24417:
URL: https://github.com/apache/flink/pull/24417#issuecomment-1972320798
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c116a9c297479ebddb59864bda83ec8dfd43bb4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c116a9c297479ebddb59864bda83ec8dfd43bb4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c116a9c297479ebddb59864bda83ec8dfd43bb4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34522][core] Changing the Time to Duration for StateTtlConfig.Builder.cleanupInRocksdbCompactFilter [flink]
Posted by "Myasuka (via GitHub)" <gi...@apache.org>.
Myasuka commented on code in PR #24417:
URL: https://github.com/apache/flink/pull/24417#discussion_r1508693480
##########
docs/content/docs/dev/datastream/fault-tolerance/state.md:
##########
@@ -610,19 +610,20 @@ StateTtlConfig ttlConfig = StateTtlConfig
import org.apache.flink.api.common.state.StateTtlConfig
val ttlConfig = StateTtlConfig
- .newBuilder(Time.seconds(1))
- .cleanupInRocksdbCompactFilter(1000, Time.hours(1))
+ .newBuilder(Duration.ofSeconds(1))
+ .cleanupInRocksdbCompactFilter(1000, Duration.ofHours(1))
.build
```
{{< /tab >}}
{{< tab "Python" >}}
```python
+from pyflink.common import Duration
from pyflink.common.time import Time
Review Comment:
As we use new interface of `Duration`, we don't need this `import` anymore.
##########
docs/content/docs/dev/datastream/fault-tolerance/state.md:
##########
@@ -491,7 +491,7 @@ import org.apache.flink.api.common.state.StateTtlConfig;
import org.apache.flink.api.common.time.Time;
Review Comment:
We don't need this import anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org