[PR] [GH-3472] Fix NaN from ST_Transform for NAD27 EPSG codes [sedona]

["jiayuasu (via GitHub)" <gi...@apache.org>]

jiayuasu opened a new pull request, #3473:
URL: https://github.com/apache/sedona/pull/3473

   ## Did you read the Contributor Guide?
   
   - Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
   
   ## Is this PR related to a ticket?
   
   - Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #3472
   
   ## What changes were proposed in this PR?
   
   ST_Transform returned POINT (NaN NaN) for every NAD27 EPSG code, including transforms between two NAD27 coordinate systems (discussion #3466). proj4sedona 0.1.6 failed the datum step when none of NAD27's optional grid files was loaded. proj4sedona 0.1.7 skips the datum shift in that case.
   
   - Bump proj4sedona from 0.1.6 to 0.1.7.
   - Add NAD27 regression tests: NAD27 to NAD27 for EPSG:32041, 32040 and 26714, NAD27 to WGS84 without a grid, and NAD27 with the NADCON grid in both directions. `testNadgridLocalFileOptionalNotFound` now checks the coordinates; it only checked for a non-null result, so it passed on POINT (NaN NaN).
   - Fix the grid file docs (English and Chinese) and the `FunctionsProj4` Javadoc. A bare name such as `@us_noaa_conus.tif` is not downloaded, so the docs examples returned NaN, or the unshifted input after this bump. The examples now use full URLs or local paths. A new section explains NAD27 EPSG codes and shows the NADCON PROJ string.
   
   ## How was this patch tested?
   
   - `common`: full suite, 1438 tests, 0 failures. On the published proj4sedona 0.1.6 the three new or tightened NAD27 tests fail with NaN.
   - `spark/common`: the CRS, GeoParquet, geotiff/netcdf metadata, function and raster algebra suites, 967 tests, 0 failures.
   - Reference values come from pyproj 3.8.0 / PROJ 9.8.1. The NADCON results match PROJ to under a millimetre.
   - The new docs examples were run against Sedona with proj4sedona 0.1.7 and match pyproj.
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [GH-3472] Fix NaN from ST_Transform for NAD27 EPSG codes [sedona]

["jiayuasu (via GitHub)" <gi...@apache.org>]

jiayuasu merged PR #3473:
URL: https://github.com/apache/sedona/pull/3473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org