[GitHub] [airflow] uranusjr commented on a diff in pull request #32118: Fix CLI commands when custom timetable is used

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #32118:
URL: https://github.com/apache/airflow/pull/32118#discussion_r1250294519


##########
airflow/cli/commands/dag_command.py:
##########
@@ -72,7 +72,13 @@ def _run_dag_backfill(dags: list[DAG], args) -> None:
 
         if args.dry_run:
             print(f"Dry run of DAG {dag.dag_id} on {args.start_date}")
-            dr = DagRun(dag.dag_id, execution_date=args.start_date)
+            dr = DagRun(
+                dag.dag_id,
+                execution_date=args.start_date,
+                data_interval=dag.timetable.infer_manual_data_interval(
+                    run_after=timezone.coerce_datetime(args.start_date)
+                ),

Review Comment:
   I think (traditionally) the distinction is that manual runs are one-off events, i.e. just one run triggered directly by the user. But both scheduled and backfill runs are triggered by the scheduler using a schedule (timetable); in the backfill case the user triggers a backfill that triggers runs. It’s kind of a made-up distinction (if I am to design things from scratch now I’d just have make everything follow the same schedule so this does not matter), but the decision was made a long time ago.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org