You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thawan Kooburat (JIRA)" <ji...@apache.org> on 2013/03/02 04:49:13 UTC

[jira] [Updated] (ZOOKEEPER-1551) Observer ignore txns that comes after snapshot and UPTODATE

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thawan Kooburat updated ZOOKEEPER-1551:
---------------------------------------

    Attachment: ZOOKEEPER-1551.patch

- Fixed indentation
- Fixed incorrect comments
- Rebase with trunk

I only print warning message since I use the same code block that we use to print warning message when we get out-of-order txn. Also, it will print false positive message when receiving the first message. Since this code block is going to be rewritten anyway in ZOOKEEPER-1549, so I don't want to put more effort on it. 

I think this patch will go to 3.4.6 only but generate patch based on trunk so that I can trigger unit test

                
> Observer ignore txns that comes after snapshot and UPTODATE 
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1551
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1551
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum, server
>    Affects Versions: 3.4.3
>            Reporter: Thawan Kooburat
>            Assignee: Thawan Kooburat
>            Priority: Blocker
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1551.patch, ZOOKEEPER-1551.patch
>
>
> In Learner.java, txns which comes after the learner has taken the snapshot (after NEWLEADER packet) are stored in packetsNotCommitted. The follower has special logic to apply these txns at the end of syncWithLeader() method. However, the observer will ignore these txns completely, causing data inconsistency. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira