You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2009/01/19 22:21:30 UTC

svn commit: r735825 - in /hadoop/hbase/trunk: CHANGES.txt build.xml src/java/org/onelab/filter/HashFunction.java

Author: stack
Date: Mon Jan 19 13:21:30 2009
New Revision: 735825

URL: http://svn.apache.org/viewvc?rev=735825&view=rev
Log:
HBASE-1136 HashFunction inadvertently destroys some randomness

Modified:
    hadoop/hbase/trunk/CHANGES.txt
    hadoop/hbase/trunk/build.xml
    hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java

Modified: hadoop/hbase/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=735825&r1=735824&r2=735825&view=diff
==============================================================================
--- hadoop/hbase/trunk/CHANGES.txt (original)
+++ hadoop/hbase/trunk/CHANGES.txt Mon Jan 19 13:21:30 2009
@@ -1,4 +1,10 @@
 HBase Change Log
+Release 0.20.0 - Unreleased
+  INCOMPATIBLE CHANGES
+
+  BUG FIXES
+   HBASE-1136   HashFunction inadvertently destroys some randomness
+
 Release 0.19.0 - Unreleased
   INCOMPATIBLE CHANGES
    HBASE-885   TableMap and TableReduce should be interfaces

Modified: hadoop/hbase/trunk/build.xml
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/build.xml?rev=735825&r1=735824&r2=735825&view=diff
==============================================================================
--- hadoop/hbase/trunk/build.xml (original)
+++ hadoop/hbase/trunk/build.xml Mon Jan 19 13:21:30 2009
@@ -18,7 +18,7 @@
 -->
 
 <project name="hbase" default="jar">
-  <property name="version" value="0.19.0"/>
+  <property name="version" value="0.20.0-dev"/>
   <property name="Name" value="HBase"/>
   <property name="final.name" value="hbase-${version}"/>
   <property name="year" value="2008"/>

Modified: hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java
URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java?rev=735825&r1=735824&r2=735825&view=diff
==============================================================================
--- hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java (original)
+++ hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java Mon Jan 19 13:21:30 2009
@@ -118,7 +118,8 @@
       }
       int[] result = new int[nbHash];
       for (int i = 0, initval = 0; i < nbHash; i++) {
-        initval = result[i] = Math.abs(hashFunction.hash(b, initval) % maxValue);
+	  initval = hashFunction.hash(b, initval);
+	  result[i] = Math.abs(initval) % maxValue;
       }
       return result;
   }//end hash()