[GitHub] ofajardo commented on issue #5392: Fix display limit in sql lab

[GitBox <gi...@apache.org>]

ofajardo commented on issue #5392: Fix display limit in sql lab
URL: https://github.com/apache/incubator-superset/pull/5392#issuecomment-459968772
 
 
   Just a comment from a confused user: I was trying queries with ORDER BY and they either were failing (Order by is not allowed in sub-queries message) or just getting things out of order. It took me some time to understand there is this select * from (yourquery) limit SQL_MAX_ROW thing, as I think it is not documented anywhere. Now I set SQL_MAX_ROW to 0 to turn that thing off and I am happy again.
   Suggestion: please leave SQL_MAX_ROW so that that subquerying can be turned off, and document that more clearly. 
   I think the display limit is good. 
   ( I have used several other SQL Editors and there was always a display limit, but I have never seen before that sub querying, that makes it really confusing for newbies).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org