You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/01/02 18:56:55 UTC
[GitHub] [nifi] sjyang18 opened a new pull request #3954: Change the
reporting behavior of Azure Reporting task to report report the time when
metrics are generated
sjyang18 opened a new pull request #3954: Change the reporting behavior of Azure Reporting task to report report the time when metrics are generated
URL: https://github.com/apache/nifi/pull/3954
#### Description of PR
Report the metrics generation time in TimeGenerated Column for Azure Reporting task; fixes bug NIFI-6977.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] sjyang18 commented on issue #3954: Change the reporting
behavior of Azure Reporting task to report report the time when metrics are
generated
Posted by GitBox <gi...@apache.org>.
sjyang18 commented on issue #3954: Change the reporting behavior of Azure Reporting task to report report the time when metrics are generated
URL: https://github.com/apache/nifi/pull/3954#issuecomment-590020991
@bahlulh Would you take a look at and vote on this PR? This has been open quite long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3954: Change the reporting
behavior of Azure Reporting task to report report the time when metrics are
generated
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #3954: Change the reporting behavior of Azure Reporting task to report report the time when metrics are generated
URL: https://github.com/apache/nifi/pull/3954#issuecomment-576020636
@sjyang18 please rebase - there was recent fix for this that created a conflict
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] sjyang18 closed pull request #3954: NIFI-6977: Change the
reporting behavior of Azure Reporting task to report report the time when
metrics are generated
Posted by GitBox <gi...@apache.org>.
sjyang18 closed pull request #3954: NIFI-6977: Change the reporting behavior of Azure Reporting task to report report the time when metrics are generated
URL: https://github.com/apache/nifi/pull/3954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] sjyang18 commented on issue #3954: Change the reporting
behavior of Azure Reporting task to report report the time when metrics are
generated
Posted by GitBox <gi...@apache.org>.
sjyang18 commented on issue #3954: Change the reporting behavior of Azure Reporting task to report report the time when metrics are generated
URL: https://github.com/apache/nifi/pull/3954#issuecomment-578558113
@joewitt , @markap14 I have rebased my PR. Thanks for reviewing my PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] sjyang18 commented on issue #3954: Change the reporting
behavior of Azure Reporting task to report report the time when metrics are
generated
Posted by GitBox <gi...@apache.org>.
sjyang18 commented on issue #3954: Change the reporting behavior of Azure Reporting task to report report the time when metrics are generated
URL: https://github.com/apache/nifi/pull/3954#issuecomment-574964449
@markap14 When you get a chance, would you review this PR? Recently, there was a PR merged, and we want to add fix on top of that merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services