You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/27 16:34:10 UTC

[GitHub] [orc] noirello opened a new pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

noirello opened a new pull request #919:
URL: https://github.com/apache/orc/pull/919


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
     2. Use your PR title to summarize what this PR proposes instead of describing the problem.
     3. Make PR title and description complete because these will be the permanent commit log.
     4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
     5. If the PR is unfinished, use GitHub PR Draft feature.
   -->
   
   ### What changes were proposed in this pull request?
   Include string in ExpressionTree.hh.
   
   
   ### Why are the changes needed?
   Without it the library cannot be built on Windows with msvc++.
   
   ### How was this patch tested?
   Manually, successfully building the library on Windows on a local machine. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #919:
URL: https://github.com/apache/orc/pull/919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928752556


   #918 is merged now. Feel free to proceed.
   BTW, I'm not sure how to re-trigger `AppVeyor`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928752556






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #919:
URL: https://github.com/apache/orc/pull/919


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] noirello commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
noirello commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928895258


   @dongjoon-hyun I just rebased on the current main branch to include #918.
   The C++ SearchArgument feature is not included in branch-1.6, but I think it would be great to include this fix in the main and branch-1.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928704113


   Thanks for the quick fix @noirello !  I will hold this fix until https://github.com/apache/orc/pull/918 is merged to make AppVeyor build happy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] noirello commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
noirello commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928895258


   @dongjoon-hyun I just rebased on the current main branch to include #918.
   The C++ SearchArgument feature is not included in branch-1.6, but I think it would be great to include this fix in the main and branch-1.7.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928754642


   Thank you, @noirello and @wgtmac . BTW, if this is for newer VC++, do we need this at main/branch-1.7/branch-1.6?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #919: ORC-1009: [C++] Missing string include causes build failure with MSVC++

Posted by GitBox <gi...@apache.org>.
wgtmac commented on pull request #919:
URL: https://github.com/apache/orc/pull/919#issuecomment-928704113


   Thanks for the quick fix @noirello !  I will hold this fix until https://github.com/apache/orc/pull/918 is merged to make AppVeyor build happy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org