[GitHub] [ignite-3] sk0x50 commented on a change in pull request #514: IGNITE-15930 Implement explicit tx argument in table API

[GitBox <gi...@apache.org>]

sk0x50 commented on a change in pull request #514:
URL: https://github.com/apache/ignite-3/pull/514#discussion_r771407633



##########
File path: modules/api/src/main/java/org/apache/ignite/table/KeyValueView.java
##########
@@ -39,35 +39,38 @@
      * Gets a value associated with the given key.
      *
      * <p>Note: If the value mapper implies a value can be {@code null}, then a suitable method
-     * {@link #getNullable(Object)} must be used instead.
+     * {@link #getNullable(Object, Transaction)} must be used instead.
      *
      * @param key A key which associated the value is to be returned. The key cannot be {@code null}.
+     * @param tx  The transaction or {@code null} to auto commit.
      * @return Value or {@code null}, if it does not exist.
      * @throws IllegalStateException If value for the key exists, and it is {@code null}.
-     * @see #getNullable(Object)
+     * @see #getNullable(Object, Transaction)
      */
-    V get(@NotNull K key);
+    V get(@NotNull K key, @Nullable Transaction tx);
 
     /**
      * Asynchronously gets a value associated with the given key.
      *
      * <p>Note: If the value mapper implies a value can be {@code null}, then a suitable method
-     * {@link #getNullableAsync(Object)} must be used instead.
+     * {@link #getNullableAsync(Object, Transaction)} must be used instead.
      *
      * @param key A key which associated the value is to be returned. The key cannot be {@code null}.
+     * @param tx  The transaction or {@code null} to auto commit.
      * @return Future representing pending completion of the operation.
-     * @see #getNullableAsync(Object)
-     * @see #get(Object)
+     * @see #getNullableAsync(Object, Transaction)
+     * @see #getNullableAsync(Object, Transaction)

Review comment:
       I think it should be as follows:
   ```
       @see #get(Object, Transaction)
       @see #getNullableAsync(Object, Transaction)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org