You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/11 13:35:06 UTC

[GitHub] [tvm] masahi edited a comment on pull request #7717: [Vulkan] Support uniform buffer object for passing many scalar arguments

masahi edited a comment on pull request #7717:
URL: https://github.com/apache/tvm/pull/7717#issuecomment-817309043


   @tqchen 
   
   * I added one `delete` but I just followed the existing use of `delete` in https://github.com/apache/tvm/blob/5bc1cec4c4acf0a54889227c1d19a6b65b6803c2/src/runtime/vulkan/vulkan.cc#L239-L241 Since we need to manually delete or free associated vk related resources anyway, I don't mind this `delete` too much
   
   *  Is there a way to make `GetMaxPushConstantSize` work for cross compilation use cases? Because for vulkan in particular, we definitely need to query HW related information like this at compile time. For example, the max thread block sizes, warp size, what extentions are available etc. I'm ok if we decide to use a fixed max push constant size, but for other HW params we need to have a solution for runtime querying. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org