You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2016/02/03 20:28:54 UTC

tika git commit: prep for TIKA-1849, miniscule clean up of RTFParser test...with clean up to the clean. mea culpa

Repository: tika
Updated Branches:
  refs/heads/2.x d6ae0a4fe -> 4843ccbf2


prep for TIKA-1849, miniscule clean up of RTFParser test...with clean up to the clean.  mea culpa


Project: http://git-wip-us.apache.org/repos/asf/tika/repo
Commit: http://git-wip-us.apache.org/repos/asf/tika/commit/4843ccbf
Tree: http://git-wip-us.apache.org/repos/asf/tika/tree/4843ccbf
Diff: http://git-wip-us.apache.org/repos/asf/tika/diff/4843ccbf

Branch: refs/heads/2.x
Commit: 4843ccbf2ead4a0c4a2bf96a127ccc13e94823ba
Parents: d6ae0a4
Author: tballison <ta...@mitre.org>
Authored: Wed Feb 3 14:28:48 2016 -0500
Committer: tballison <ta...@mitre.org>
Committed: Wed Feb 3 14:28:48 2016 -0500

----------------------------------------------------------------------
 .../org/apache/tika/parser/rtf/RTFParserTest.java     | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tika/blob/4843ccbf/tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/rtf/RTFParserTest.java
----------------------------------------------------------------------
diff --git a/tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/rtf/RTFParserTest.java b/tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/rtf/RTFParserTest.java
index ea50463..365de77 100644
--- a/tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/rtf/RTFParserTest.java
+++ b/tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/rtf/RTFParserTest.java
@@ -27,7 +27,6 @@ import java.io.FileInputStream;
 import java.io.InputStream;
 import java.io.StringWriter;
 import java.util.ArrayList;
-import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
@@ -510,15 +509,18 @@ public class RTFParserTest extends TikaTest {
 
         assertTrue(meta_jpg_exif != null);
         assertTrue(meta_jpg != null);
-        assertTrue(Arrays.asList(meta_jpg_exif.getValues("dc:subject")).contains("serbor"));
-        assertTrue(meta_jpg.get("Comments").contains("Licensed to the Apache"));
+        // had to comment these out (when moving from 1.x to 2.x
+        // because AutoDetectParser within this module does not include image parsing.
+
+//        assertTrue(Arrays.asList(meta_jpg_exif.getValues("dc:subject")).contains("serbor"));
+//        assertTrue(meta_jpg.get("Comments").contains("Licensed to the Apache"));
         //make sure old metadata doesn't linger between objects
-        assertFalse(Arrays.asList(meta_jpg.getValues("dc:subject")).contains("serbor"));
+//        assertFalse(Arrays.asList(meta_jpg.getValues("dc:subject")).contains("serbor"));
         assertEquals("false", meta_jpg.get(RTFMetadata.THUMBNAIL));
         assertEquals("false", meta_jpg_exif.get(RTFMetadata.THUMBNAIL));
 
-        assertEquals(46, meta_jpg.names().length);
-        assertEquals(110, meta_jpg_exif.names().length);
+        assertEquals(25, meta_jpg.names().length);
+        assertEquals(25, meta_jpg_exif.names().length);
     }
 
     @Test