You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by on...@apache.org on 2021/10/12 05:57:11 UTC
[geode] branch develop updated: GEODE-9629: remove factory method
added to public API (#6978)
This is an automated email from the ASF dual-hosted git repository.
onichols pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/develop by this push:
new e8942b7 GEODE-9629: remove factory method added to public API (#6978)
e8942b7 is described below
commit e8942b794ce9ee9dc9c15320e6936b2d150b2a7c
Author: Owen Nichols <34...@users.noreply.github.com>
AuthorDate: Mon Oct 11 22:56:05 2021 -0700
GEODE-9629: remove factory method added to public API (#6978)
---
.../java/org/apache/geode/cache/wan/GatewaySenderFactory.java | 8 --------
.../geode/internal/cache/wan/InternalGatewaySenderFactory.java | 8 ++++++++
.../java/org/apache/geode/internal/cache/wan/WANTestBase.java | 4 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java b/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java
index 687bf12..6c9e92b 100644
--- a/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java
+++ b/geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderFactory.java
@@ -50,14 +50,6 @@ public interface GatewaySenderFactory {
GatewaySenderFactory setGroupTransactionEvents(boolean groupTransactionEvents);
/**
- * Sets the maximum number of retries to get events from the queue
- * to complete a transaction when groupTransactionEvents is true.
- *
- * @param retries the maximum number of retries.
- */
- GatewaySenderFactory setRetriesToGetTransactionEventsFromQueue(int retries);
-
- /**
* Adds a <code>GatewayEventFilter</code>
*
* @param filter GatewayEventFilter
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/wan/InternalGatewaySenderFactory.java b/geode-core/src/main/java/org/apache/geode/internal/cache/wan/InternalGatewaySenderFactory.java
index f2690f8..6b941c8 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/wan/InternalGatewaySenderFactory.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/wan/InternalGatewaySenderFactory.java
@@ -32,4 +32,12 @@ public interface InternalGatewaySenderFactory extends GatewaySenderFactory {
void configureGatewaySender(GatewaySender senderCreation);
GatewaySenderFactory setLocatorDiscoveryCallback(LocatorDiscoveryCallback myLocatorCallback);
+
+ /**
+ * Sets the maximum number of retries to get events from the queue
+ * to complete a transaction when groupTransactionEvents is true.
+ *
+ * @param retries the maximum number of retries.
+ */
+ GatewaySenderFactory setRetriesToGetTransactionEventsFromQueue(int retries);
}
diff --git a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
index 1721a54..1b8c444 100644
--- a/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
+++ b/geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
@@ -1759,9 +1759,9 @@ public class WANTestBase extends DistributedTestCase {
numDispatcherThreadsForTheRun, GatewaySender.DEFAULT_ORDER_POLICY,
GatewaySender.DEFAULT_SOCKET_BUFFER_SIZE);
gateway.setGroupTransactionEvents(groupTransactionEvents);
- if (groupTransactionEvents) {
+ if (groupTransactionEvents && gateway instanceof InternalGatewaySenderFactory) {
// Set a very high value to avoid flakiness in test cases
- gateway.setRetriesToGetTransactionEventsFromQueue(100);
+ ((InternalGatewaySenderFactory) gateway).setRetriesToGetTransactionEventsFromQueue(100);
}
gateway.create(dsName, remoteDsId);
} finally {