You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:26:02 UTC
[GitHub] [camel] jamesnetherton opened a new pull request #3901: CAMEL-15144: Add capability to customize BindableService class generation
jamesnetherton opened a new pull request #3901:
URL: https://github.com/apache/camel/pull/3901
https://issues.apache.org/jira/browse/CAMEL-15144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton commented on a change in pull request #3901: CAMEL-15144: Add capability to customize BindableService class generation
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #3901:
URL: https://github.com/apache/camel/pull/3901#discussion_r437344898
##########
File path: components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConstants.java
##########
@@ -50,4 +50,9 @@
String GRPC_EVENT_TYPE_ON_NEXT = "onNext";
String GRPC_EVENT_TYPE_ON_ERROR = "onError";
String GRPC_EVENT_TYPE_ON_COMPLETED = "onCompleted";
+
+ /*
+ * The registry key to lookup a custom BindableServiceFactory
+ */
+ String GRPC_BINDABLE_SERVICE_FACTORY_NAME = "bindableServiceFactory";
Review comment:
Yeah, good point. I'll do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #3901: CAMEL-15144: Add capability to customize BindableService class generation
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #3901:
URL: https://github.com/apache/camel/pull/3901#discussion_r437339686
##########
File path: components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConstants.java
##########
@@ -50,4 +50,9 @@
String GRPC_EVENT_TYPE_ON_NEXT = "onNext";
String GRPC_EVENT_TYPE_ON_ERROR = "onError";
String GRPC_EVENT_TYPE_ON_COMPLETED = "onCompleted";
+
+ /*
+ * The registry key to lookup a custom BindableServiceFactory
+ */
+ String GRPC_BINDABLE_SERVICE_FACTORY_NAME = "bindableServiceFactory";
Review comment:
I wonder if we should prefix it with grpc, eg grpcBindableServiceFactory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jamesnetherton merged pull request #3901: CAMEL-15144: Add capability to customize BindableService class generation
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #3901:
URL: https://github.com/apache/camel/pull/3901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org