You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2008/10/28 19:15:44 UTC

[jira] Created: (ZOOKEEPER-211) Not all Mock tests are working

Not all Mock tests are working
------------------------------

                 Key: ZOOKEEPER-211
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
             Project: Zookeeper
          Issue Type: Test
          Components: c client
            Reporter: Benjamin Reed
            Priority: Minor
         Attachments: ZOOKEEPER-211.patch

For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar reassigned ZOOKEEPER-211:
---------------------------------------

    Assignee: Benjamin Reed

ben can you explain what the bug is and how its fixed in the patch?

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Minor
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649323#action_12649323 ] 

Hudson commented on ZOOKEEPER-211:
----------------------------------

Integrated in ZooKeeper-trunk #149 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/149/])
    

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Minor
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-211:
------------------------------------

    Attachment: ZOOKEEPER-211.patch

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Priority: Minor
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-211:
-----------------------------------

    Fix Version/s: 3.1.0
                   3.0.1

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Minor
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643336#action_12643336 ] 

Benjamin Reed commented on ZOOKEEPER-211:
-----------------------------------------

In ZKMock originally I enqueued the SetWatcher response right after the handshake since I knew that that would be the next request received. This patch changes it to enqueue the response when it receives the SetWatcher request.

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Minor
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-211:
------------------------------------

    Status: Patch Available  (was: Open)

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Priority: Minor
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-211:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Looks good, +1

branch: Committed revision 718831.
trunk: Committed revision 718832.


> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Minor
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-211) Not all Mock tests are working

Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645505#action_12645505 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-211:
--------------------------------------------------

+ 1, looks good, Ben.

> Not all Mock tests are working
> ------------------------------
>
>                 Key: ZOOKEEPER-211
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-211
>             Project: Zookeeper
>          Issue Type: Test
>          Components: c client
>            Reporter: Benjamin Reed
>            Assignee: Benjamin Reed
>            Priority: Minor
>             Fix For: 3.0.1, 3.1.0
>
>         Attachments: ZOOKEEPER-211.patch
>
>
> For the 3.0 release there was a bug in the ZKMock code that prevented some tests from working. This patch fixes the bug and reenables the tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.