Re: svn commit: r1462436 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs_fs/caching.c libsvn_fs_fs/fs_fs.c svnadmin/svnadmin.c

[Stefan Fuhrmann <st...@wandisco.com>]

On Fri, Mar 29, 2013 at 8:22 PM, Daniel Shahaf <da...@elego.de> wrote:

> stefan2@apache.org wrote on Fri, Mar 29, 2013 at 10:39:18 -0000:
> > Author: stefan2
> > Date: Fri Mar 29 10:39:18 2013
> > New Revision: 1462436
> >
> > URL: http://svn.apache.org/r1462436
> > Log:
> > Introduce the concept of namespaces to FSFS caching.  We already use
> > "prefixes" to separate keys from different repos.  Now, we can add
> > another element to the prefix and we will do so if we need to ensure
> > that all data get read from disk at least initially.
> >
> > Make all verification code use a unique cache namespace.
> >
> > * subversion/include/svn_fs.h
> >   (SVN_FS_CONFIG_FSFS_CACHE_NS): declare new config option
> >
> > * subversion/libsvn_fs_fs/caching.c
> >   (read_config): read namespace from config
> >   (svn_fs_fs__initialize_caches): add namespace to prefix
> >
>
> Does tree.c:make_txn_root() need to use the new config option when it
> calls svn_cache__create_inprocess()?


No. "inprocess" caches are local / private to the FS instance.
Historically, the name was chosen to contrast it with the memcached
based cache, which was out-of-process. Today, that name can be
misleading.

With 1.9, we may use membuffer caches for everything (each txn
would use its own namespace) and maybe even drop alternative
svn_cache__t implementations. But I'm not too eager to do that.

-- Stefan^2.

-- 
*Join one of our free daily demo sessions on* *Scaling Subversion for the
Enterprise <http://www.wandisco.com/training/webinars>*
*

*