[jira] [Commented] (FLINK-7664) Replace FlinkFutureException by CompletionException

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175144#comment-16175144 ] 

ASF GitHub Bot commented on FLINK-7664:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4701

    [FLINK-7664] Replace FlinkFutureException by java.util.concurrent.CompletionException

    ## What is the purpose of the change
    
    FlinkFutureException was introduced to fail a CompletableFuture callback. However, there
    was already such a class which allows to better handle failures in different stages which
    is the java.util.CompletionException. Therefore we replace FlinkFutureException by
    CompletionException and remove the former.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeFlinkFutureException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4701
    
----
commit 3b94ca218e6ed4c8fc0fe491d33c072473651a9b
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-09-21T17:21:07Z

    [FLINK-7664] Replace FlinkFutureException by java.util.concurrent.CompletionException
    
    FlinkFutureException was introduced to fail a CompletableFuture callback. However, there
    was already such a class which allows to better handle failures in different stages which
    is the java.util.CompletionException. Therefore we replace FlinkFutureException by
    CompletionException and remove the former.

----


> Replace FlinkFutureException by CompletionException
> ---------------------------------------------------
>
>                 Key: FLINK-7664
>                 URL: https://issues.apache.org/jira/browse/FLINK-7664
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> The {{FlinkFutureException}} was introduced to fail in a {{CompletableFuture}} callback. This can, however, better be done via the {{CompletionException}}. Therefore, we should remove the {{FlinkFutureException}} and replace it with the {{CompletionException}} instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)