[GitHub] kpm1985 commented on issue #989: FLUO-768 Improve Oracle log message

[GitBox <gi...@apache.org>]

kpm1985 commented on issue #989: FLUO-768 Improve Oracle log message
URL: https://github.com/apache/fluo/pull/989#issuecomment-354002897
 
 
   Thank you for the catch! Dyslexic mistake for sure. Just opened a corrected
   PR.
   
   On Dec 26, 2017 10:35 AM, "Mike Walch" <no...@github.com> wrote:
   
   > *@mikewalch* requested changes on this pull request.
   >
   > Code change looks good to me but the issue number should be #786
   > <https://github.com/apache/fluo/issues/786>
   >
   > This isn't required but I think it's a nice practice. If you use 'Closes
   > #786 <https://github.com/apache/fluo/issues/786>' or 'Fixes #786
   > <https://github.com/apache/fluo/issues/786>' in commit messages rather
   > than 'FLUO-786' the '#786 <https://github.com/apache/fluo/issues/786>'
   > becomes a link to the issue and the issue will be closed automatically by
   > GitHub when the commit gets into the master branch.
   >
   > ?
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fluo/pull/989#pullrequestreview-85579615>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/Acg-LPkXU4ES8JjjT2I9siwI96PR3gPgks5tETyGgaJpZM4RM7PI>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services