You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by vi...@apache.org on 2014/12/08 22:40:06 UTC
svn commit: r1643937 -
/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
Author: violetagg
Date: Mon Dec 8 21:40:06 2014
New Revision: 1643937
URL: http://svn.apache.org/r1643937
Log:
Additional method was introduced to StandardRoot in order to be able to extend classResources.
Modified:
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java?rev=1643937&r1=1643936&r2=1643937&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java (original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Mon Dec 8 21:40:06 2014
@@ -461,6 +461,11 @@ public class StandardRoot extends Lifecy
return classResources.toArray(new WebResourceSet[0]);
}
+ protected void addClassResources(WebResourceSet webResourceSet) {
+ webResourceSet.setRoot(this);
+ classResources.add(webResourceSet);
+ }
+
@Override
public void setAllowLinking(boolean allowLinking) {
this.allowLinking = allowLinking;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1643937 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
Posted by Violeta Georgieva <mi...@gmail.com>.
Hi Mark,
2014-12-09 1:22 GMT+02:00 Mark Thomas <ma...@apache.org>:
>
> On 08/12/2014 21:40, violetagg@apache.org wrote:
> > Author: violetagg
> > Date: Mon Dec 8 21:40:06 2014
> > New Revision: 1643937
> >
> > URL: http://svn.apache.org/r1643937
> > Log:
> > Additional method was introduced to StandardRoot in order to be able to
extend classResources.
> >
> > Modified:
> > tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
> >
> > Modified:
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java?rev=1643937&r1=1643936&r2=1643937&view=diff
> >
==============================================================================
> > ---
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
(original)
> > +++
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Mon
Dec 8 21:40:06 2014
> > @@ -461,6 +461,11 @@ public class StandardRoot extends Lifecy
> > return classResources.toArray(new WebResourceSet[0]);
> > }
> >
> > + protected void addClassResources(WebResourceSet webResourceSet) {
> > + webResourceSet.setRoot(this);
> > + classResources.add(webResourceSet);
> > + }
> > +
>
> This looks suspicious too. What is the use case here?
I answered in http://marc.info/?t=141802961800003&r=1&w=2
Let's continue the discussion there.
Thanks,
Violeta
> Mark
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: svn commit: r1643937 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
Posted by Mark Thomas <ma...@apache.org>.
On 08/12/2014 21:40, violetagg@apache.org wrote:
> Author: violetagg
> Date: Mon Dec 8 21:40:06 2014
> New Revision: 1643937
>
> URL: http://svn.apache.org/r1643937
> Log:
> Additional method was introduced to StandardRoot in order to be able to extend classResources.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java?rev=1643937&r1=1643936&r2=1643937&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Mon Dec 8 21:40:06 2014
> @@ -461,6 +461,11 @@ public class StandardRoot extends Lifecy
> return classResources.toArray(new WebResourceSet[0]);
> }
>
> + protected void addClassResources(WebResourceSet webResourceSet) {
> + webResourceSet.setRoot(this);
> + classResources.add(webResourceSet);
> + }
> +
This looks suspicious too. What is the use case here?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org