[GitHub] [spark] zhouyejoe commented on a diff in pull request #37624: [SPARK-40186][CORE][YARN] Ensure `mergedShuffleCleaner` have been shutdown before `db` close

[GitBox <gi...@apache.org>]

zhouyejoe commented on code in PR #37624:
URL: https://github.com/apache/spark/pull/37624#discussion_r953356051


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -795,13 +796,25 @@ public void registerExecutor(String appId, ExecutorShuffleInfo executorInfo) {
   }
 
   /**
-   * Close the DB during shutdown
+   * Shutdown mergedShuffleCleaner and close the DB during shutdown
    */
   @Override
   public void close() {
+    if (!mergedShuffleCleaner.isShutdown()) {
+      try {
+        mergedShuffleCleaner.shutdown();
+        boolean terminated = mergedShuffleCleaner.awaitTermination(10L, TimeUnit.SECONDS);
+        if (!terminated) {
+          mergedShuffleCleaner.shutdownNow();
+        }
+      } catch (InterruptedException ignored) {
+        // ignore InterruptedException.
+      }
+    }

Review Comment:
   Just wondering should we follow the example provided in Java doc with 2 phase shutdown?
   https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ExecutorService.html. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org