You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org> on 2011/03/10 15:52:02 UTC

[jira] Commented: (WICKET-3521) Make BookmarkablePageLink non-generic

    [ https://issues.apache.org/jira/browse/WICKET-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005086#comment-13005086 ] 

Bertrand Guay-Paquet commented on WICKET-3521:
----------------------------------------------

After further review, I found there is still a way to give a BookmarkablePageLink a model via aBookmarkablePageLink.setModel(). However, many of the usual overridable methods of Link<T> are final in BookmarkablePageLink so there is not much use for this model.

> Make BookmarkablePageLink non-generic
> -------------------------------------
>
>                 Key: WICKET-3521
>                 URL: https://issues.apache.org/jira/browse/WICKET-3521
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.5-RC2
>            Reporter: Bertrand Guay-Paquet
>            Priority: Trivial
>
> BookmarkablePageLink is currently a generic type. I propose to change its class signature to :
> public class BookmarkablePageLink extends Link<Void>
> I can't find any use for the parameter T since there is no BookmarkablePageLink which takes a model (like Link does).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira