You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/09/01 04:47:16 UTC

[GitHub] [hive] pvary commented on pull request #2344: HIVE-23633: Metastore some JDO query objects do not close …

pvary commented on pull request #2344:
URL: https://github.com/apache/hive/pull/2344#issuecomment-909880973


   Thanks for catching this! 
   
   We should close all the queries, even if there is an exception.
   Since Java 8 closing queries in `try-with-resources` would be the best if possible, falling back to `finally` when not possible is the second best.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org