You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2019/05/29 18:04:31 UTC
[GitHub] [fineract-cn-mobile] miPlodder commented on a change in pull
request #49: Improved Hamburger Menu
miPlodder commented on a change in pull request #49: Improved Hamburger Menu
URL: https://github.com/apache/fineract-cn-mobile/pull/49#discussion_r288698153
##########
File path: app/src/main/res/layout/layout_nav_header.xml
##########
@@ -13,26 +13,43 @@
android:paddingTop="@dimen/activity_vertical_margin"
android:theme="@style/ThemeOverlay.AppCompat.Dark">
- <ImageView
- android:id="@+id/imageView"
- android:layout_height="wrap_content"
- android:layout_width="wrap_content"
- android:paddingTop="@dimen/nav_header_vertical_spacing"
- app:srcCompat="@android:drawable/sym_def_app_icon"/>
-
- <TextView
- android:layout_height="wrap_content"
+ <RelativeLayout
android:layout_width="match_parent"
- android:paddingTop="@dimen/nav_header_vertical_spacing"
- android:text="Rajan Maurya"
- android:textColor="@color/white"
- android:textAppearance="@style/TextAppearance.AppCompat.Body1"/>
+ android:layout_height="match_parent"
+ android:gravity="center"
+ >
+
+ <ImageView
+ android:layout_width="match_parent"
Review comment:
Remove this ImageView. It's not a good UI design to show Organisation image on Hamburger Header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services