You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/11 23:55:01 UTC

[jira] [Commented] (CB-13057) Remove cordova platform save command

    [ https://issues.apache.org/jira/browse/CB-13057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16286791#comment-16286791 ] 

ASF GitHub Bot commented on CB-13057:
-------------------------------------

stevengill commented on a change in pull request #586: CB-13057 : Remove cordova platform save command
URL: https://github.com/apache/cordova-lib/pull/586#discussion_r156235679
 
 

 ##########
 File path: integration-tests/pkgJson.spec.js
 ##########
 @@ -621,15 +621,15 @@ describe('During add, if pkg.json has a platform/plugin spec, use that one.', fu
         var iosVersion;
         var cwd = process.cwd();
         var iosDirectory = path.join(cwd, 'platforms/ios/cordova/version');
-        var platformsFolderPath = path.join(cwd, 'platforms/platforms.json');
+        //var platformsFolderPath = path.join(cwd, 'platforms/platforms.json');
 
 Review comment:
   delete

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove cordova platform save command
> ------------------------------------
>
>                 Key: CB-13057
>                 URL: https://issues.apache.org/jira/browse/CB-13057
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-lib
>    Affects Versions: cordova@8
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: backlog, tools-next
>             Fix For: cordova@8
>
>
> With autosaving now in place, we don't need `cordova platform save` anymore.
> By removing this command, we can also remove cordovaProject/platforms/platforms.json & cordova-lib/src/cordova/platform_metadata.js
> Deprecation notice will be added to cordova platform save until save command is removed in cordova@8



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org