You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Michele Milesi <mi...@icteam.it> on 2017/05/15 10:51:49 UTC
Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3128
https://issues.apache.org/jira/browse/SQOOP-3128
Repository: sqoop-trunk
Description
-------
Fix for documentation issue SQOOP-3128.
Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
Diffs
-----
src/docs/user/connectors.txt 7c54071
Diff: https://reviews.apache.org/r/59267/diff/1/
Testing
-------
No test executed: fixed a markdown file.
Thanks,
Michele Milesi
Re: Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175098
-----------------------------------------------------------
Ship it!
Ship It!
- Szabolcs Vasas
On May 15, 2017, 10:51 a.m., Michele Milesi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59267/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3128
> https://issues.apache.org/jira/browse/SQOOP-3128
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for documentation issue SQOOP-3128.
> Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 7c54071
>
>
> Diff: https://reviews.apache.org/r/59267/diff/1/
>
>
> Testing
> -------
>
> No test executed: fixed a markdown file.
>
>
> Thanks,
>
> Michele Milesi
>
>
Re: Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
Posted by Michele Milesi <mi...@icteam.it>.
> On Mag. 16, 2017, 1:59 p.m., Szabolcs Vasas wrote:
> > Hi Michele,
> >
> > The change seems correct to me since these tables are used in a query in org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition method which is used from org.apache.sqoop.manager.oracle.OraOopDataDrivenDBInputFormat#getSplits which runs during an import.
> >
> > Regards,
> > Szabolcs
Hi Szabolcs
I've crawled the source code before configure our Oracle :)
BTW it's my first patch for Sqoop, I've to close/submit it now? Or I've to await more +1?
Thanks and regards
Michele
- Michele
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175101
-----------------------------------------------------------
On Mag. 15, 2017, 10:51 a.m., Michele Milesi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59267/
> -----------------------------------------------------------
>
> (Updated Mag. 15, 2017, 10:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3128
> https://issues.apache.org/jira/browse/SQOOP-3128
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for documentation issue SQOOP-3128.
> Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 7c54071
>
>
> Diff: https://reviews.apache.org/r/59267/diff/1/
>
>
> Testing
> -------
>
> No test executed: fixed a markdown file.
>
>
> Thanks,
>
> Michele Milesi
>
>
Re: Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
Posted by Michele Milesi <mi...@icteam.it>.
> On Mag. 16, 2017, 3:59 p.m., Szabolcs Vasas wrote:
> > Hi Michele,
> >
> > The change seems correct to me since these tables are used in a query in org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition method which is used from org.apache.sqoop.manager.oracle.OraOopDataDrivenDBInputFormat#getSplits which runs during an import.
> >
> > Regards,
> > Szabolcs
>
> Michele Milesi wrote:
> Hi Szabolcs
> I've crawled the source code before configure our Oracle :)
>
> BTW it's my first patch for Sqoop, I've to close/submit it now? Or I've to await more +1?
>
> Thanks and regards
> Michele
>
> Szabolcs Vasas wrote:
> Your patch should be reviewed by a committer too who will put your change in trunk. You can add Anna Szonyi or Attila Szabo to this review they are pretty active committers.
>
> Szabolcs
Thanks Szabolcs
Michele
- Michele
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175101
-----------------------------------------------------------
On Mag. 15, 2017, 12:51 p.m., Michele Milesi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59267/
> -----------------------------------------------------------
>
> (Updated Mag. 15, 2017, 12:51 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3128
> https://issues.apache.org/jira/browse/SQOOP-3128
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for documentation issue SQOOP-3128.
> Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 7c54071
>
>
> Diff: https://reviews.apache.org/r/59267/diff/1/
>
>
> Testing
> -------
>
> No test executed: fixed a markdown file.
>
>
> Thanks,
>
> Michele Milesi
>
>
Re: Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
Posted by Szabolcs Vasas <va...@gmail.com>.
> On May 16, 2017, 1:59 p.m., Szabolcs Vasas wrote:
> > Hi Michele,
> >
> > The change seems correct to me since these tables are used in a query in org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition method which is used from org.apache.sqoop.manager.oracle.OraOopDataDrivenDBInputFormat#getSplits which runs during an import.
> >
> > Regards,
> > Szabolcs
>
> Michele Milesi wrote:
> Hi Szabolcs
> I've crawled the source code before configure our Oracle :)
>
> BTW it's my first patch for Sqoop, I've to close/submit it now? Or I've to await more +1?
>
> Thanks and regards
> Michele
Your patch should be reviewed by a committer too who will put your change in trunk. You can add Anna Szonyi or Attila Szabo to this review they are pretty active committers.
Szabolcs
- Szabolcs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175101
-----------------------------------------------------------
On May 15, 2017, 10:51 a.m., Michele Milesi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59267/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3128
> https://issues.apache.org/jira/browse/SQOOP-3128
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for documentation issue SQOOP-3128.
> Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 7c54071
>
>
> Diff: https://reviews.apache.org/r/59267/diff/1/
>
>
> Testing
> -------
>
> No test executed: fixed a markdown file.
>
>
> Thanks,
>
> Michele Milesi
>
>
Re: Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175101
-----------------------------------------------------------
Hi Michele,
The change seems correct to me since these tables are used in a query in org.apache.sqoop.manager.oracle.OraOopOracleQueries#getOracleDataChunksPartition method which is used from org.apache.sqoop.manager.oracle.OraOopDataDrivenDBInputFormat#getSplits which runs during an import.
Regards,
Szabolcs
- Szabolcs Vasas
On May 15, 2017, 10:51 a.m., Michele Milesi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59267/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3128
> https://issues.apache.org/jira/browse/SQOOP-3128
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for documentation issue SQOOP-3128.
> Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 7c54071
>
>
> Diff: https://reviews.apache.org/r/59267/diff/1/
>
>
> Testing
> -------
>
> No test executed: fixed a markdown file.
>
>
> Thanks,
>
> Michele Milesi
>
>
Re: Review Request 59267: SQOOP-3128 - Missing privileges in "Oracle
Roles and Privileges" paragraph (section 25.8.2.2)
Posted by Michele Milesi <mi...@icteam.it>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59267/#review175100
-----------------------------------------------------------
Ship it!
Inviala!
- Michele Milesi
On Mag. 15, 2017, 10:51 a.m., Michele Milesi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59267/
> -----------------------------------------------------------
>
> (Updated Mag. 15, 2017, 10:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3128
> https://issues.apache.org/jira/browse/SQOOP-3128
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Fix for documentation issue SQOOP-3128.
> Updated the Sqoop User Guide, section 25.8.2.2. Oracle Roles and Privileges.
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 7c54071
>
>
> Diff: https://reviews.apache.org/r/59267/diff/1/
>
>
> Testing
> -------
>
> No test executed: fixed a markdown file.
>
>
> Thanks,
>
> Michele Milesi
>
>