[GitHub] [helix] qqu0127 commented on a diff in pull request #2219: Upgrade to zookeeper 3.6.3

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2219:
URL: https://github.com/apache/helix/pull/2219#discussion_r975840709


##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestRawZkClient.java:
##########
@@ -1063,23 +1063,25 @@ public void testAsyncWriteByExpectedSession() throws Exception {
    * Tests getChildren() when there are an excessive number of children and connection loss happens,
    * the operation should terminate and exit retry loop.
    */
-  @Test(timeOut = 30 * 1000L)
+  @Test
   public void testGetChildrenOnLargeNumChildren() throws Exception {
     final String methodName = TestHelper.getTestMethodName();
     System.out.println("Start test: " + methodName);
+    String[] nodePaths = new String[110001];

Review Comment:
   I assume it's 110 * 1000 + 1 ? 
   nit: Let's use constants and multiplication for these numbers. Same as below in the for-loop. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org