You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Kevin J. Menard, Jr. (JIRA)" <ta...@jakarta.apache.org> on 2006/12/05 15:16:22 UTC
[jira] Created: (TAPESTRY-1174) Review validation error messages.
Review validation error messages.
---------------------------------
Key: TAPESTRY-1174
URL: http://issues.apache.org/jira/browse/TAPESTRY-1174
Project: Tapestry
Issue Type: Task
Affects Versions: 4.1.1
Reporter: Kevin J. Menard, Jr.
Priority: Minor
The validation error messages have changed between T4.0.x and 4.1.x. The change was made in an attempt to provide a better hint to the user about what made their input invalid. There is some dispute on the user list as to whether the changes made overly complicate things or actually make things easier for the user.
Moreover, there's dispute about whether changing the messages is considered a backwards-incompatible change. Developers may have come to rely on these messages and not expect the change. In my own case, it broke integration tests I had that checked for the presence of a particular error message.
There's also dispute over whether the detailed messages are more appropriate for developers or for end users. If this is all the issue comes down to, adding a "debug" property might be a nice compromise for switching between the two (although, maintaining two sets of messages may be cumbersome).
At the very least, the changes should be reviewed and some general consensus reached about how to move forward.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1174) Review validation error messages.
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1174?page=all ]
Jesse Kuhnert updated TAPESTRY-1174:
------------------------------------
Fix Version/s: 4.1.1
Yeah, it will be changed back to the old messages - just need a little more time for my next wave of tap dev to do it.
> Review validation error messages.
> ---------------------------------
>
> Key: TAPESTRY-1174
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1174
> Project: Tapestry
> Issue Type: Task
> Affects Versions: 4.1.1
> Reporter: Kevin J. Menard, Jr.
> Priority: Minor
> Fix For: 4.1.1
>
>
> The validation error messages have changed between T4.0.x and 4.1.x. The change was made in an attempt to provide a better hint to the user about what made their input invalid. There is some dispute on the user list as to whether the changes made overly complicate things or actually make things easier for the user.
> Moreover, there's dispute about whether changing the messages is considered a backwards-incompatible change. Developers may have come to rely on these messages and not expect the change. In my own case, it broke integration tests I had that checked for the presence of a particular error message.
> There's also dispute over whether the detailed messages are more appropriate for developers or for end users. If this is all the issue comes down to, adding a "debug" property might be a nice compromise for switching between the two (although, maintaining two sets of messages may be cumbersome).
> At the very least, the changes should be reviewed and some general consensus reached about how to move forward.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1174) Review validation error messages.
Posted by "Sam Gendler (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1174?page=comments#action_12455754 ]
Sam Gendler commented on TAPESTRY-1174:
---------------------------------------
I don't know enough about hivemind, but if it is possible to use hivemind to allow a user to override the properties en-masse, then it would definitely be useful to many a developer to have validation messages that do contain developer-specific info like format patterns or even the entire string that was passed to the validators binding of the component. I'd love to be able to run with developer messages right up through most of the QA cycle, so that when errors get reported, I've got as much info as possible, just not at the expense of having to manually override all the built-in messages.
> Review validation error messages.
> ---------------------------------
>
> Key: TAPESTRY-1174
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1174
> Project: Tapestry
> Issue Type: Task
> Affects Versions: 4.1.1
> Reporter: Kevin J. Menard, Jr.
> Priority: Minor
> Fix For: 4.1.1
>
>
> The validation error messages have changed between T4.0.x and 4.1.x. The change was made in an attempt to provide a better hint to the user about what made their input invalid. There is some dispute on the user list as to whether the changes made overly complicate things or actually make things easier for the user.
> Moreover, there's dispute about whether changing the messages is considered a backwards-incompatible change. Developers may have come to rely on these messages and not expect the change. In my own case, it broke integration tests I had that checked for the presence of a particular error message.
> There's also dispute over whether the detailed messages are more appropriate for developers or for end users. If this is all the issue comes down to, adding a "debug" property might be a nice compromise for switching between the two (although, maintaining two sets of messages may be cumbersome).
> At the very least, the changes should be reviewed and some general consensus reached about how to move forward.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Resolved: (TAPESTRY-1174) Review validation error messages.
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-1174?page=all ]
Jesse Kuhnert resolved TAPESTRY-1174.
-------------------------------------
Resolution: Fixed
Assignee: Jesse Kuhnert
Fixed the numeric/number based strings.
I noticed that dates get this "format is " string but can't remember if that is something I added or not. Either way I think it actually does make sense for dates so will probably need some stronger convincing if that isn't what others think.
> Review validation error messages.
> ---------------------------------
>
> Key: TAPESTRY-1174
> URL: http://issues.apache.org/jira/browse/TAPESTRY-1174
> Project: Tapestry
> Issue Type: Task
> Affects Versions: 4.1.1
> Reporter: Kevin J. Menard, Jr.
> Assigned To: Jesse Kuhnert
> Priority: Minor
> Fix For: 4.1.1
>
>
> The validation error messages have changed between T4.0.x and 4.1.x. The change was made in an attempt to provide a better hint to the user about what made their input invalid. There is some dispute on the user list as to whether the changes made overly complicate things or actually make things easier for the user.
> Moreover, there's dispute about whether changing the messages is considered a backwards-incompatible change. Developers may have come to rely on these messages and not expect the change. In my own case, it broke integration tests I had that checked for the presence of a particular error message.
> There's also dispute over whether the detailed messages are more appropriate for developers or for end users. If this is all the issue comes down to, adding a "debug" property might be a nice compromise for switching between the two (although, maintaining two sets of messages may be cumbersome).
> At the very least, the changes should be reviewed and some general consensus reached about how to move forward.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org