You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dlab.apache.org by GitBox <gi...@apache.org> on 2020/03/17 03:51:52 UTC
[GitHub] [incubator-dlab] ppapou opened a new pull request #659: [DLAB-1623]
Stopping of the Edge node
ppapou opened a new pull request #659: [DLAB-1623] Stopping of the Edge node
URL: https://github.com/apache/incubator-dlab/pull/659
The interface of the stopWithResources method has been adjusted.
Cuurently, the procedure stops the endoints, which have been passed thought the related resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #659:
[DLAB-1623] Stopping of the Edge node
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #659: [DLAB-1623] Stopping of the Edge node
URL: https://github.com/apache/incubator-dlab/pull/659#discussion_r393690095
##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/ProjectServiceImpl.java
##########
@@ -165,15 +165,17 @@ public void stop(UserInfo userInfo, List<String> endpoints, String name) {
}
@Override
- public void stopWithResources(UserInfo userInfo, String projectName) {
- List<ProjectEndpointDTO> endpoints = get(projectName).getEndpoints();
- checkProjectRelatedResourcesInProgress(projectName, endpoints, STOP_ACTION);
+ public void stopWithResources(UserInfo userInfo, List<String> endpoints, String projectName) {
+ List<ProjectEndpointDTO> endpointDTOS = get(projectName)
+ .getEndpoints().stream().
+ filter(projectEndpointDTO -> endpoints.contains(projectEndpointDTO.getName())).collect(Collectors.toList());
Review comment:
Lets follow stream convention:
list
.stream()
.filter()
.collect()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks commented on a change in pull request #659:
[DLAB-1623] Stopping of the Edge node
Posted by GitBox <gi...@apache.org>.
ofuks commented on a change in pull request #659: [DLAB-1623] Stopping of the Edge node
URL: https://github.com/apache/incubator-dlab/pull/659#discussion_r393689378
##########
File path: services/self-service/src/main/java/com/epam/dlab/backendapi/service/impl/ProjectServiceImpl.java
##########
@@ -165,15 +165,17 @@ public void stop(UserInfo userInfo, List<String> endpoints, String name) {
}
@Override
- public void stopWithResources(UserInfo userInfo, String projectName) {
- List<ProjectEndpointDTO> endpoints = get(projectName).getEndpoints();
- checkProjectRelatedResourcesInProgress(projectName, endpoints, STOP_ACTION);
+ public void stopWithResources(UserInfo userInfo, List<String> endpoints, String projectName) {
+ List<ProjectEndpointDTO> endpointDTOS = get(projectName)
Review comment:
endpointDTOS -> endpointDTOs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org
[GitHub] [incubator-dlab] ofuks merged pull request #659: [DLAB-1623]
Stopping of the Edge node
Posted by GitBox <gi...@apache.org>.
ofuks merged pull request #659: [DLAB-1623] Stopping of the Edge node
URL: https://github.com/apache/incubator-dlab/pull/659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@dlab.apache.org
For additional commands, e-mail: dev-help@dlab.apache.org