[GitHub] [incubator-seatunnel] BenJFan commented on a diff in pull request #1949: [Api-draft] Add seatunnel kafka source connectors

[GitBox <gi...@apache.org>]

BenJFan commented on code in PR #1949:
URL: https://github.com/apache/incubator-seatunnel/pull/1949#discussion_r882376524


##########
seatunnel-core/seatunnel-flink-starter/src/main/java/org/apache/seatunnel/core/starter/flink/execution/FlinkTaskExecution.java:
##########
@@ -46,7 +47,8 @@ public class FlinkTaskExecution {
 
     public FlinkTaskExecution(Config config) {
         this.config = config;
-        this.flinkEnvironment = createFlinkEnvironment();
+        this.flinkEnvironment = (FlinkEnvironment) new EnvironmentFactory<>(config, EngineType.FLINK).getEnvironment();

Review Comment:
   I change the EnvironmentFactory and FlinkEnvironment to support change `job.mode` and create `StreamExecutionEnvironment`. So this method will work, this way have any problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org