You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hsun-cnnxty <gi...@git.apache.org> on 2016/07/26 01:28:40 UTC
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
GitHub user hsun-cnnxty opened a pull request:
https://github.com/apache/storm/pull/1591
STORM-1038: Upgrade netty to 4.x in 1.x-branch
This is to add the feature to 1.x-branch. The original PR for master branch is #728.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsun-cnnxty/storm 1.x-branch-netty4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-25T22:30:54Z
STORM-1038: Upgraded netty to 4.x
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
GitHub user hsun-cnnxty reopened a pull request:
https://github.com/apache/storm/pull/1591
STORM-1038: Upgrade netty to 4.x in 1.x-branch
This is to add the feature to 1.x-branch. The original PR for master branch is #728.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsun-cnnxty/storm 1.x-branch-netty4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-25T22:30:54Z
STORM-1038: Upgraded netty to 4.x
commit 144b6eddf314ce9a0b5beb8c99500c56ff0b8ec0
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-30T23:42:52Z
STORM-1038: removed unused imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
You can close and reopen this PR to retrigger. Btw, apache repository seems to be unstable recent days. I saw other build failures due to repository connectivity issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1591#discussion_r73129527
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/KerberosSaslClientHandler.java ---
@@ -46,56 +44,48 @@ public KerberosSaslClientHandler(ISaslClient client, Map storm_conf, String jaas
}
@Override
- public void channelConnected(ChannelHandlerContext ctx,
- ChannelStateEvent event) {
+ public void channelActive(ChannelHandlerContext ctx) throws Exception {
// register the newly established channel
- Channel channel = ctx.getChannel();
- client.channelConnected(channel);
+ Channel channel = ctx.channel();
+ client.channelReady();
LOG.info("Connection established from {} to {}",
- channel.getLocalAddress(), channel.getRemoteAddress());
+ channel.localAddress(), channel.remoteAddress());
try {
- KerberosSaslNettyClient saslNettyClient = KerberosSaslNettyClientState.getKerberosSaslNettyClient
- .get(channel);
+ KerberosSaslNettyClient saslNettyClient = channel.attr(KerberosSaslNettyClientState.KERBEROS_SASL_NETTY_CLIENT).get();
if (saslNettyClient == null) {
LOG.debug("Creating saslNettyClient now for channel: {}",
channel);
saslNettyClient = new KerberosSaslNettyClient(storm_conf, jaas_section);
- KerberosSaslNettyClientState.getKerberosSaslNettyClient.set(channel,
- saslNettyClient);
+ channel.attr(KerberosSaslNettyClientState.KERBEROS_SASL_NETTY_CLIENT).set(saslNettyClient);
}
LOG.debug("Going to initiate Kerberos negotiations.");
byte[] initialChallenge = saslNettyClient.saslResponse(new SaslMessageToken(new byte[0]));
LOG.debug("Sending initial challenge: {}", initialChallenge);
- channel.write(new SaslMessageToken(initialChallenge));
+ channel.writeAndFlush(new SaslMessageToken(initialChallenge));
--- End diff --
Why is it changed to use `writeAndFlush`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty closed the pull request at:
https://github.com/apache/storm/pull/1591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
Seems the Travis CI build will fail at random places which are not related to this PR.
For example the last build failed due to
`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.2.1:process (default) on project flux-examples: Error resolving project artifact: Could not transfer artifact io.confluent:kafka-schema-registry-client:pom:1.0 from/to sonatype-apache (https://repository.apache.org/releases/): Connect to repository.apache.org:443 [repository.apache.org/207.244.88.143] failed: Connection timed out for project io.confluent:kafka-schema-registry-client:jar:1.0 -> [Help 1]
`
Any way to manually trigger a new CI build w/o code change?
-thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty closed the pull request at:
https://github.com/apache/storm/pull/1591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty closed the pull request at:
https://github.com/apache/storm/pull/1591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on a diff in the pull request:
https://github.com/apache/storm/pull/1591#discussion_r77873290
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -73,6 +73,20 @@
public static final String STORM_MESSAGING_NETTY_BUFFER_SIZE = "storm.messaging.netty.buffer_size";
/**
+ * Netty based messaging: The write buffer high water mark for write buffer
--- End diff --
Will take a look at how to improve. Any suggestions?
-thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/1591
@hsun-cnnxty `Channel#write` is modified to `Channel#writeAndFlush` at multiple places. Does not that flush to the underlying stream without buffering and flush it when buffers are full?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
I will find some time this weekend to work on it.
-thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
Please rebase and force push accordingly. Your PR now has all of the commits from other side.
You can give it an another try: 1) create new branch based on recent master or 1.x 2) cherry-pick your commits 3) checkout to your PR branch 4) reset your PR branch to the branch which you just worked 4) force push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
@satishd nett 4.x has removed auto-flush in write() and it requires user to explicitly call flush() or writeAndFlush(), so we need to flush for the last message in the logic flow. Fortunately, the storm netty client does batching of messages itself and it does not flush for every message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty closed the pull request at:
https://github.com/apache/storm/pull/1591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1591
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
Since Netty made 3.x version line EOL, I'd like to bump Netty to 4.0.x or even 4.1.x if there's no performance / resource usage issue.
@hsun-cnnxty
Please upmerge this. If you really don't mind, could you do performance tests again on two latest versions: 4.0.41.Final and 4.1.5.Final, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
Performance test results are attached here.
[perf_compare_netty_3vs4_1.x-branch.zip](https://github.com/apache/storm/files/392165/perf_compare_netty_3vs4_1.x-branch.zip)
Baseline: current head of 1.x-branch (e55684b164fe99823a4ae3562b62867a26aaba97)
Netty4: 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
In addition to default configuration,
io.netty.noPreferDirect=false
io.netty.allocator.type=pooled
following configurations are also tested for netty 4.x
-unpool
io.netty.allocator.type=unpooled. Ask Netty to not use pooled allocation for buffer
-nodirect
io.netty.noPreferDirect=true. Ask Netty to not use off-heap buffer allocation
-unpool-nodirect
io.netty.noPreferDirect=true
io.netty.allocator.type=unpooled
Due to the capacity of my laptop, I tested following loads: 2k, 5k, 10k. At 10k, the CPU usage reaches above 85% and failures started to appear at startup.
The performance data seems to suggest
- no big difference is observed comparing before/after netty upgrades
I suspect only a small percentage of traffic will cross worker instances (jvm) so Netty does not play a big role in performance measured
- netty 4.x consumes a little more CPU and memory
The small memory increment may be simply b/c netty 4.x pulled in more classes.
- netty 4.x has lower CPU consumption on GC
This is especially visible with the default configuration where off-heap buffer allocation is used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1591#discussion_r75354518
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -73,6 +73,20 @@
public static final String STORM_MESSAGING_NETTY_BUFFER_SIZE = "storm.messaging.netty.buffer_size";
/**
+ * Netty based messaging: The write buffer high water mark for write buffer
--- End diff --
These config descriptions are not descriptive. Without reading the code, I have no idea what this does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
GitHub user hsun-cnnxty reopened a pull request:
https://github.com/apache/storm/pull/1591
STORM-1038: Upgrade netty to 4.x in 1.x-branch
This is to add the feature to 1.x-branch. The original PR for master branch is #728.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsun-cnnxty/storm 1.x-branch-netty4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-25T22:30:54Z
STORM-1038: Upgraded netty to 4.x
commit 144b6eddf314ce9a0b5beb8c99500c56ff0b8ec0
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-30T23:42:52Z
STORM-1038: removed unused imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty closed the pull request at:
https://github.com/apache/storm/pull/1591
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
@hsun-cnnxty
Sorry I lost tracking this.
From the last time I tested on my local machine (via ThroughputVsLatency), before patching this works better than after patching this. My test environment seems not stable.
Someone might need to test on this, and if he/she can run benchmark with multi machines that should be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
Tests are done to compare following two code bases:
- baseline: current head of 1.x-branch (62476f5237a72938c1f0d3fe65dbcdc446a2bd12)
- netty 4.1.x: 1.x-branch-netty4 (dd96d9f4ba5b8da8d68845d7796d29de8bdbe3b8)
In summary:
- netty 4.1.x is able to sustain higher throughput (20k/sec) than baseline (between 15k -20k/sec)
- netty 4.1.x has lower GC activity which could be the reason that it has higher throughput**
Also tested different netty configurations regarding buffer allocation
- use direct buffer or heap
- use pooled or unpooled
Result shows the default setting works best.
Performance tests are done on my laptop with following config:
Model Name: MacBook Pro
Processor Name: Intel Core i7
Processor Speed: 2.3 GHz
Number of Processors: 1
Total Number of Cores: 4
L2 Cache (per Core): 256 KB
L3 Cache: 6 MB
Memory: 16 GB
System Version: OS X 10.10.5 (14F27)
Kernel Version: Darwin 14.5.0
The data collected is attached.
[performance_compare_netty_1.x-branch.zip](https://github.com/apache/storm/files/503682/performance_compare_netty_1.x-branch.zip)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
GitHub user hsun-cnnxty reopened a pull request:
https://github.com/apache/storm/pull/1591
STORM-1038: Upgrade netty to 4.x in 1.x-branch
This is to add the feature to 1.x-branch. The original PR for master branch is #728.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsun-cnnxty/storm 1.x-branch-netty4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-25T22:30:54Z
STORM-1038: Upgraded netty to 4.x
commit 144b6eddf314ce9a0b5beb8c99500c56ff0b8ec0
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-30T23:42:52Z
STORM-1038: removed unused imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
GitHub user hsun-cnnxty reopened a pull request:
https://github.com/apache/storm/pull/1591
STORM-1038: Upgrade netty to 4.x in 1.x-branch
This is to add the feature to 1.x-branch. The original PR for master branch is #728.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsun-cnnxty/storm 1.x-branch-netty4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-25T22:30:54Z
STORM-1038: Upgraded netty to 4.x
commit 144b6eddf314ce9a0b5beb8c99500c56ff0b8ec0
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-30T23:42:52Z
STORM-1038: removed unused imports
commit 286287fb20968f8bb27e0b596ddd8008c71bc593
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:01:28Z
STORM-1995: close input stream and other tweaks to downloadChunk
* manually applying f38982c (via @abellina)
commit d16ce38f99077012af3a77b5b46a42733845f140
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:02:47Z
Merge branch 'STORM-1996-1.x' into 1.x-branch
commit 40e215249065e799a7539f95b0f6f6fac3138c29
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:14:47Z
add STORM-1995 to CHANGELOG
commit fe5157bf35ed21e4ecf2edb7c5bc9d1402713384
Author: lujinhong <lu...@gmail.com>
Date: 2016-06-27T02:33:28Z
STORM-1594 org.apache.storm.tuple.Fields can throw NPE if given invalid field in selector
* Closes #1522
commit d48e97fbfdde4f3be03ce1bbb357b3b7c8f19e2f
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:33:16Z
Merge branch 'STORM-1594-1.x' into 1.x-branch
commit 14924e3ea54bd8204b6b8a5bdde444db81a2ad09
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:33:41Z
add STORM-1594 to CHANGELOG
commit eed4b42358faf0eef2585a402fbe342b10a2edc3
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Date: 2016-08-03T04:35:10Z
Merge branch 'STORM-1839' of https://github.com/priyank5485/storm into STORM-1839
commit f4480ade9aa124152b4946b9c6b9d90103128300
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Date: 2016-08-03T04:59:42Z
Added STORM-1839 to CHANGELOG.
commit 8355c9ee269efa3f61ee25b4f8515ca5ad196a24
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-05T07:16:33Z
fix parent version of storm-kinesis module
commit 636b780eb30a6ec7a88bdc87af87001dcbe2456a
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Date: 2016-07-28T03:37:40Z
STORM-1890: looks like too many calls were moved to getStatic. It doesnt break things, but it is sloppy, so reverting some to $.get
commit f38a38e8260ace2147bde4f80e103e7a2e542a4f
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2016-08-04T16:09:59Z
STORM-2021: Fix License
commit 0253657f6ea4997cc9af95c428ad2b171fa13390
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-08T03:35:24Z
Merge branch 'storm-kinesis-version-fix-1.x' into 1.x-branch
commit d51e696b7d538a5dda97a71960b3d6d04ea4e311
Author: Manikumar Reddy O <ma...@gmail.com>
Date: 2016-07-21T11:57:03Z
STORM-1979: Storm Druid Connector implementation. This uses Druid's tranquility library.
commit 7e90b93f7c8831cb31f9bac1df7db22d1b3fe7c4
Author: Satish Duggana <sd...@hortonworks.com>
Date: 2016-08-09T05:28:19Z
Added STORM-1979 to CHANGELOG
commit 70383db6a16b8b904d81aaf68518db6cc15398c4
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-09T08:07:59Z
fix parent version of storm-druid pom in 1.x branch
commit fe25aa6019c16968cfcd35adb7a72b0295417879
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-08-10T19:46:52Z
Revert "[maven-release-plugin] prepare for next development iteration"
This reverts commit 1d0b50302c1287c9567fa17eede9e0a598381651.
commit 9e9ec4347db572ba93021b05ea8dd0e3aeadccd6
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-08-10T19:46:57Z
Revert "[maven-release-plugin] prepare release v1.1.0"
This reverts commit 4d80461a62e6f739dccff79af176bc109bc491e7.
commit b5458b8ee4668d31a67629fcf0eb4aa3978ef521
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-11T14:43:55Z
Fix parent version of storm-druid and storm-kinesis
* during the rollback they still keep versions since it's manually fixed after the release process
commit c5cf73b9078176482d273907c79ca8e9a1e85498
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-06-17T17:59:06Z
Improvements for Trident RAS API.
commit d50a2437923f2919fbee130b8e9e86a62a2d9f48
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date: 2016-05-04T22:08:57Z
[STORM-1766] - A better algorithm server rack selection for RAS
commit 9bd21ca6efd67fd84c340cd0250f8c0b31ec9ff1
Author: Boyang Jerry Peng <je...@gmail.com>
Date: 2016-03-11T20:21:16Z
[STORM-2036] - Fix minor bug in RAS Tests
commit ce51159fc407f52b82a8dacf86e25e8284e177df
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date: 2016-08-11T16:42:36Z
Add STORM-2036 to Changelog
commit ba942a48491531a663203272b353d9a9f300fc17
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2016-08-11T14:24:59Z
STORM-2032 removes warning in case more than one metrics tuple is received
* changes level of potentially confusing log message to DEBUG
* Closes #1618
commit c3bb87563295702f1739f36c548dec4ac5ae38c9
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-12T01:29:20Z
Merge branch 'STORM-2032-1.x' into 1.x-branch
commit 076b00c7457003f47547f3ad240d21e8fab28412
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-12T01:30:30Z
add STORM-2032 to CHANGELOG
commit aac1f8df85146ff7440789c432ca0950aa2922f8
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-11T23:27:39Z
STORM-1999 Update docs with OutputCollector's threadsafety
* From Storm 1.0.0, OutputCollector is thread safe
commit 8c7f3772b8f3498191933a5f47ec7a2731201499
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-12T01:45:23Z
Merge branch 'STORM-1999-1.x' into 1.x-branch
commit bfeb8ca0d49f2e0f1d7aa211b9b61415b821cec5
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-05T09:16:13Z
STORM-2023 Add calcite-core to dependency of storm-sql-runtime
* also copy (transitive) dependencies to binary distribute, as storm-sql-core did
* split default directory name into words (appassembler -> app-assembler)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
GitHub user hsun-cnnxty reopened a pull request:
https://github.com/apache/storm/pull/1591
STORM-1038: Upgrade netty to 4.x in 1.x-branch
This is to add the feature to 1.x-branch. The original PR for master branch is #728.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsun-cnnxty/storm 1.x-branch-netty4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1591.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1591
----
commit 57fbccc7e0d710ccaf04a5a828f0ff4cf29ec855
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-25T22:30:54Z
STORM-1038: Upgraded netty to 4.x
commit 144b6eddf314ce9a0b5beb8c99500c56ff0b8ec0
Author: Hang Sun <hs...@connexity.com>
Date: 2016-07-30T23:42:52Z
STORM-1038: removed unused imports
commit 286287fb20968f8bb27e0b596ddd8008c71bc593
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:01:28Z
STORM-1995: close input stream and other tweaks to downloadChunk
* manually applying f38982c (via @abellina)
commit d16ce38f99077012af3a77b5b46a42733845f140
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:02:47Z
Merge branch 'STORM-1996-1.x' into 1.x-branch
commit 40e215249065e799a7539f95b0f6f6fac3138c29
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:14:47Z
add STORM-1995 to CHANGELOG
commit fe5157bf35ed21e4ecf2edb7c5bc9d1402713384
Author: lujinhong <lu...@gmail.com>
Date: 2016-06-27T02:33:28Z
STORM-1594 org.apache.storm.tuple.Fields can throw NPE if given invalid field in selector
* Closes #1522
commit d48e97fbfdde4f3be03ce1bbb357b3b7c8f19e2f
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:33:16Z
Merge branch 'STORM-1594-1.x' into 1.x-branch
commit 14924e3ea54bd8204b6b8a5bdde444db81a2ad09
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-31T14:33:41Z
add STORM-1594 to CHANGELOG
commit eed4b42358faf0eef2585a402fbe342b10a2edc3
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Date: 2016-08-03T04:35:10Z
Merge branch 'STORM-1839' of https://github.com/priyank5485/storm into STORM-1839
commit f4480ade9aa124152b4946b9c6b9d90103128300
Author: Sriharsha Chintalapani <ha...@hortonworks.com>
Date: 2016-08-03T04:59:42Z
Added STORM-1839 to CHANGELOG.
commit 8355c9ee269efa3f61ee25b4f8515ca5ad196a24
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-05T07:16:33Z
fix parent version of storm-kinesis module
commit 636b780eb30a6ec7a88bdc87af87001dcbe2456a
Author: Alessandro Bellina <ab...@yahoo-inc.com>
Date: 2016-07-28T03:37:40Z
STORM-1890: looks like too many calls were moved to getStatic. It doesnt break things, but it is sloppy, so reverting some to $.get
commit f38a38e8260ace2147bde4f80e103e7a2e542a4f
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2016-08-04T16:09:59Z
STORM-2021: Fix License
commit 0253657f6ea4997cc9af95c428ad2b171fa13390
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-08T03:35:24Z
Merge branch 'storm-kinesis-version-fix-1.x' into 1.x-branch
commit d51e696b7d538a5dda97a71960b3d6d04ea4e311
Author: Manikumar Reddy O <ma...@gmail.com>
Date: 2016-07-21T11:57:03Z
STORM-1979: Storm Druid Connector implementation. This uses Druid's tranquility library.
commit 7e90b93f7c8831cb31f9bac1df7db22d1b3fe7c4
Author: Satish Duggana <sd...@hortonworks.com>
Date: 2016-08-09T05:28:19Z
Added STORM-1979 to CHANGELOG
commit 70383db6a16b8b904d81aaf68518db6cc15398c4
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-09T08:07:59Z
fix parent version of storm-druid pom in 1.x branch
commit fe25aa6019c16968cfcd35adb7a72b0295417879
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-08-10T19:46:52Z
Revert "[maven-release-plugin] prepare for next development iteration"
This reverts commit 1d0b50302c1287c9567fa17eede9e0a598381651.
commit 9e9ec4347db572ba93021b05ea8dd0e3aeadccd6
Author: P. Taylor Goetz <pt...@gmail.com>
Date: 2016-08-10T19:46:57Z
Revert "[maven-release-plugin] prepare release v1.1.0"
This reverts commit 4d80461a62e6f739dccff79af176bc109bc491e7.
commit b5458b8ee4668d31a67629fcf0eb4aa3978ef521
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-11T14:43:55Z
Fix parent version of storm-druid and storm-kinesis
* during the rollback they still keep versions since it's manually fixed after the release process
commit c5cf73b9078176482d273907c79ca8e9a1e85498
Author: Kyle Nusbaum <ky...@gmail.com>
Date: 2016-06-17T17:59:06Z
Improvements for Trident RAS API.
commit d50a2437923f2919fbee130b8e9e86a62a2d9f48
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date: 2016-05-04T22:08:57Z
[STORM-1766] - A better algorithm server rack selection for RAS
commit 9bd21ca6efd67fd84c340cd0250f8c0b31ec9ff1
Author: Boyang Jerry Peng <je...@gmail.com>
Date: 2016-03-11T20:21:16Z
[STORM-2036] - Fix minor bug in RAS Tests
commit ce51159fc407f52b82a8dacf86e25e8284e177df
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date: 2016-08-11T16:42:36Z
Add STORM-2036 to Changelog
commit ba942a48491531a663203272b353d9a9f300fc17
Author: Derek Dagit <de...@yahoo-inc.com>
Date: 2016-08-11T14:24:59Z
STORM-2032 removes warning in case more than one metrics tuple is received
* changes level of potentially confusing log message to DEBUG
* Closes #1618
commit c3bb87563295702f1739f36c548dec4ac5ae38c9
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-12T01:29:20Z
Merge branch 'STORM-2032-1.x' into 1.x-branch
commit 076b00c7457003f47547f3ad240d21e8fab28412
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-12T01:30:30Z
add STORM-2032 to CHANGELOG
commit aac1f8df85146ff7440789c432ca0950aa2922f8
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-11T23:27:39Z
STORM-1999 Update docs with OutputCollector's threadsafety
* From Storm 1.0.0, OutputCollector is thread safe
commit 8c7f3772b8f3498191933a5f47ec7a2731201499
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-12T01:45:23Z
Merge branch 'STORM-1999-1.x' into 1.x-branch
commit bfeb8ca0d49f2e0f1d7aa211b9b61415b821cec5
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-08-05T09:16:13Z
STORM-2023 Add calcite-core to dependency of storm-sql-runtime
* also copy (transitive) dependencies to binary distribute, as storm-sql-core did
* split default directory name into words (appassembler -> app-assembler)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1591: STORM-1038: Upgrade netty to 4.x in 1.x-branch
Posted by hsun-cnnxty <gi...@git.apache.org>.
Github user hsun-cnnxty commented on the issue:
https://github.com/apache/storm/pull/1591
@HeartSaVioR
I rebased to 1.x-branch and also squashed the commits. Will attached the performance test results soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---