You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/12 04:45:21 UTC
[GitHub] [beam] dependabot[bot] opened a new pull request, #22231: Bump mypy-protobuf from 1.18 to 2.10 in /sdks/python
dependabot[bot] opened a new pull request, #22231:
URL: https://github.com/apache/beam/pull/22231
Bumps [mypy-protobuf](https://github.com/dropbox/mypy-protobuf) from 1.18 to 2.10.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/nipunn1313/mypy-protobuf/blob/main/CHANGELOG.md">mypy-protobuf's changelog</a>.</em></p>
<blockquote>
<h2>2.10</h2>
<ul>
<li>Switch from setup.py to pyproject.toml and setup.cfg per <a href="https://packaging.python.org/tutorials/packaging-projects/">https://packaging.python.org/tutorials/packaging-projects/</a></li>
<li>Remove dependency on grpcio-tools. mypy-protobuf doesn't need it to run. It's only needed to run mypy afterward.</li>
<li>Avoid relative imports in <code>_grpc_pb2.pyi</code> stubs. grpc stubs themselves don't use relative imports, nor <code>__init__.py</code> files</li>
<li>Use <code>"""</code> docstring style comments in generated code rather than <code>#</code> style so it shows up in IDEs.</li>
<li>Disambiguate messages from reserved python keywords (eg <code>None</code>) with prefix <code>_r_</code> rather than <code>__</code> - since <code>__</code> is considered private.</li>
<li>Bump tests to use pyright 1.1.169, types-protobuf 3.17.4, pytest 6.2.5, grpc-stubs 1.24.7, grpcio-tools 1.40.0</li>
<li>Since upstream protobuf has dropped support with 3.18.0, 2.10 will be the last mypy-protobuf that supports targeting python 2.7. Updated docs for this.</li>
</ul>
<h2>2.9</h2>
<ul>
<li><a href="https://github.com/github/renaming">Rename master branch to main</a></li>
<li>Make <code>install_requires</code> requirements for grpcio-tools and types-protobuf use >=</li>
</ul>
<h2>2.8</h2>
<ul>
<li>Propagate comments from .proto files to .pyi files</li>
<li>Add protobuf type stubs to the setup requirements</li>
<li>Fix <a href="https://github-redirect.dependabot.com/nipunn1313/mypy-protobuf/issues/239">#239</a> Remove type: ignore used in enum by pulling <code>V</code> into a separate class.</li>
<li>Use pytest 6.2.4 for internal test suites on python3</li>
<li>Remove <code>protoc_gen_mypy.bat</code> as the entry-points method creates protoc-gen-mypy.exe. Add test confirming.</li>
</ul>
<h2>2.7</h2>
<ul>
<li>Fix <a href="https://github-redirect.dependabot.com/nipunn1313/mypy-protobuf/issues/244">#244</a> - support extensions defined at module scope with proper types, matching extensions defined within Messages. See <a href="https://github.com/python/typeshed/blob/4765978f6ceeb24e10bdf93c0d4b72dfb35836d4/stubs/protobuf/google/protobuf/internal/extension_dict.pyi#L9"><code>_ExtensionDict</code></a></li>
</ul>
<pre lang="proto"><code>extend google.protobuf.MessageOptions {
string test_message_option = 51234;
}
</code></pre>
<pre lang="python"><code># Used to generate
test_message_option: google.protobuf.descriptor.FieldDescriptor = ...
<h1>Now generates</h1>
<p>test_message_option: google.protobuf.internal.extension_dict._ExtensionFieldDescriptor[google.protobuf.descriptor_pb2.MessageOptions, typing.Text] = ...
</code></pre></p>
<p>Fix repeated extensions as well - to generate RepeatedScalarFieldContainer and RepeatedCompositeFieldContainer</p>
<ul>
<li>Now requires <a href="https://pypi.org/project/types-protobuf/">types-protobuf</a> 3.17.3</li>
<li>Fix <a href="https://github-redirect.dependabot.com/nipunn1313/mypy-protobuf/issues/238">#238</a> - handling enum variants that name conflict with EnumTypeWrapper methods</li>
<li>Improve mypy-protobuf testsuite expected-errors file to make insertions/deletions easier to code review</li>
<li>Fix <a href="https://github-redirect.dependabot.com/nipunn1313/mypy-protobuf/issues/227">#227</a> - improve support for messages/enums with python reserved keyword names</li>
<li>Order fields within a message in original .proto file order Previously, they were grouped by scalar/nonscalar. Remove
that grouping to make it a bit easier to correlate .proto files to .pyi files.</li>
</ul>
<h2>2.6</h2>
<ul>
<li>Bump protoc support to 3.17.3</li>
<li>Use latest python versions in tests (3.6.14 3.7.11 3.8.11 3.9.6)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/4aee8be58e47c58405025e160ddec010c945db45"><code>4aee8be</code></a> Bump release to mypy_protobuf 2.10 (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/288">#288</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/0be5aa22a5200e6c2d7db406ace406abaf62b6e1"><code>0be5aa2</code></a> Bump pyright, types-protobuf, pytest, grpc-stubs, grpcio-tools (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/286">#286</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/255c60a405b6ef7a171036fab3ffbfb364d37c92"><code>255c60a</code></a> Disambiguate reserved keywords with "<em>r</em>" rather than "__" (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/287">#287</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/9a5cb794f8033801397c44373a1fa4cf829a122a"><code>9a5cb79</code></a> Set test requirements to <3.18.0 for final 2.7 release mypy_protobuf==2.10 (#...</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/864bbf4accd128605895e1464477f4dc58291884"><code>864bbf4</code></a> Add Comment propagation as a feature in the README</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/2a5b81ace9dbc90d9924e2cdd3b9e61418c76605"><code>2a5b81a</code></a> Use docstring style comments instead of # comments (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/281">#281</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/13f2ca3cb43ee7205f30943049d717841154f9f7"><code>13f2ca3</code></a> Avoid relative imports in grpc code (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/278">#278</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/bd793afd459d0b907fe71de1e36025606e29881a"><code>bd793af</code></a> Use pyproject.toml instead of mypy.ini (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/274">#274</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/6a34fb0ec04a13fe22a5074e995d565f5f049ac4"><code>6a34fb0</code></a> Validate that _pb2.py files have been generated (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/273">#273</a>)</li>
<li><a href="https://github.com/nipunn1313/mypy-protobuf/commit/ed129dccfc71679d8dfbf743b14d6283672b8b63"><code>ed129dc</code></a> Commit the generated .pyi files (<a href="https://github-redirect.dependabot.com/dropbox/mypy-protobuf/issues/272">#272</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/dropbox/mypy-protobuf/compare/v1.18...v2.10">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22231: Bump mypy-protobuf from 1.18 to 2.10 in /sdks/python
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22231:
URL: https://github.com/apache/beam/pull/22231#issuecomment-1374827606
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22231: Bump mypy-protobuf from 1.18 to 2.10 in /sdks/python
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22231:
URL: https://github.com/apache/beam/pull/22231#issuecomment-1246835687
# [Codecov](https://codecov.io/gh/apache/beam/pull/22231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22231](https://codecov.io/gh/apache/beam/pull/22231?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec82af3) into [master](https://codecov.io/gh/apache/beam/commit/70f1c71525903b9d0474efab476c0e199267e757?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70f1c71) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #22231 +/- ##
==========================================
- Coverage 73.58% 73.58% -0.01%
==========================================
Files 716 716
Lines 95316 95316
==========================================
- Hits 70140 70139 -1
- Misses 23880 23881 +1
Partials 1296 1296
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.40% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/22231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.42% <0.00%> (-0.25%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/22231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `88.94% <0.00%> (-0.16%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/22231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.43% <0.00%> (+0.38%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22231: Bump mypy-protobuf from 1.18 to 2.10 in /sdks/python
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22231:
URL: https://github.com/apache/beam/pull/22231#issuecomment-1242722305
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22231: Bump mypy-protobuf from 1.18 to 2.10 in /sdks/python
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22231:
URL: https://github.com/apache/beam/pull/22231#issuecomment-1181353980
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org