You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/28 15:31:29 UTC
[GitHub] [airflow] mjpieters opened a new pull request #10632: Log task_instance execution duration as milliseconds
mjpieters opened a new pull request #10632:
URL: https://github.com/apache/airflow/pull/10632
This is best achieved by passing a `timedelta()` to `Stats.timing()`, and leave worrying about time units to that method.
This is my fix for #10629, for the master branch. A separate pull request will be made for the v1-10 branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mjpieters commented on a change in pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
mjpieters commented on a change in pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#discussion_r479633824
##########
File path: airflow/models/taskinstance.py
##########
@@ -1184,7 +1184,7 @@ def signal_handler(signum, frame): # pylint: disable=unused-argument
task_copy.post_execute(context=context, result=result)
end_time = time.time()
- duration = end_time - start_time
+ duration = timedelta(seconds=end_time - start_time)
Review comment:
No, `time.time()` is a float value representing seconds, see the [documentation](https://docs.python.org/3/library/time.html#time.time). So `duration` is the difference, in seconds, between start and end time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #10632:
URL: https://github.com/apache/airflow/pull/10632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mjpieters commented on pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
mjpieters commented on pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#issuecomment-714824814
> Hmmm all the K8s tests failing is a worrying sign. Could you rebase and see if that fixes it?
Rebased, and the only failure looks unrelated and flakey to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mjpieters commented on pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
mjpieters commented on pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#issuecomment-715365283
I don't _think_ the RabbitMQ and OpenLDAP Kerberos services failure to start have anything to do with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#discussion_r479503960
##########
File path: airflow/models/taskinstance.py
##########
@@ -1184,7 +1184,7 @@ def signal_handler(signum, frame): # pylint: disable=unused-argument
task_copy.post_execute(context=context, result=result)
end_time = time.time()
- duration = end_time - start_time
+ duration = timedelta(seconds=end_time - start_time)
Review comment:
Isn't that microseconds ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#issuecomment-682716995
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#issuecomment-713897242
Hmmm all the K8s tests failing is a worrying sign. Could you rebase and see if that fixes it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mjpieters commented on a change in pull request #10632: Log task_instance execution duration as milliseconds
Posted by GitBox <gi...@apache.org>.
mjpieters commented on a change in pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#discussion_r479633824
##########
File path: airflow/models/taskinstance.py
##########
@@ -1184,7 +1184,7 @@ def signal_handler(signum, frame): # pylint: disable=unused-argument
task_copy.post_execute(context=context, result=result)
end_time = time.time()
- duration = end_time - start_time
+ duration = timedelta(seconds=end_time - start_time)
Review comment:
No, `time.time()` is a float value representing seconds, see the [documentation](https://docs.python.org/3/library/time.html#time.time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org