Re: Improve handling of + in URLs

[Ilya Khlopotov <ii...@apache.org>]

Hi Noah,

Thank you for the PR and the discussion thread. I am in favor of accepting this change for main.
However would like to hear an opinion from one of the PMCs.  Since it is a breaking change which changes the behavior.

Best regards,
ILYA 

On 2021/06/28 19:18:26, Noah Shaw <no...@yahoo.com.INVALID> wrote: 
> Hi all,
> I have implemented an approach that no longer encodes '+' into space in non-query parts of URLs. Since this changes the current behavior of CouchDB, I would like to create a discussion for this. Please see https://github.com/apache/couchdb/pull/3638.
> Thanks,
> Noah Shaw

Re: Improve handling of + in URLs

[Jan Lehnardt <ja...@apache.org>]

Hi all,

> On 28. Jul 2021, at 12:49, Ilya Khlopotov <ii...@apache.org> wrote:
> 
> Hi Noah,
> 
> Thank you for the PR and the discussion thread. I am in favor of accepting this change for main.
> However would like to hear an opinion from one of the PMCs.  Since it is a breaking change which changes the behavior.

I also agree with the changes here, my only concern with with rolling them out. Bob had relayed my opinion in his comment at https://github.com/apache/couchdb/pull/3638#issuecomment-888419524 <https://github.com/apache/couchdb/pull/3638#issuecomment-888419524>

That is:

1. introduce a config flag to toggle the old/new behaviour
2. make the change opt-in in 3.x
3. make the change opt-out in 4.x

Best
Jan
— 
Professional Support for Apache CouchDB:
https://neighbourhood.ie/couchdb-support/

24/7 Observation for your CouchDB Instances:
https://opservatory.app <https://opservatory.app/>

> 
> Best regards,
> ILYA 
> 
> On 2021/06/28 19:18:26, Noah Shaw <no...@yahoo.com.INVALID> wrote: 
>> Hi all,
>> I have implemented an approach that no longer encodes '+' into space in non-query parts of URLs. Since this changes the current behavior of CouchDB, I would like to create a discussion for this. Please see https://github.com/apache/couchdb/pull/3638.
>> Thanks,
>> Noah Shaw