You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pankajastro (via GitHub)" <gi...@apache.org> on 2023/04/20 09:43:38 UTC

[GitHub] [airflow] pankajastro commented on a diff in pull request #30761: Deprecate Databricks Deferrable Operator

pankajastro commented on code in PR #30761:
URL: https://github.com/apache/airflow/pull/30761#discussion_r1172345106


##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -384,10 +391,23 @@ def on_kill(self):
         else:
             self.log.error("Error: Task: %s with invalid run_id was requested to be cancelled.", self.task_id)
 
+    def execute_complete(self, context: dict | None, event: dict):
+        _handle_deferrable_databricks_operator_completion(event, self.log)
+
 
 class DatabricksSubmitRunDeferrableOperator(DatabricksSubmitRunOperator):
     """Deferrable version of ``DatabricksSubmitRunOperator``"""
 
+    def __init__(self, *args, **kwargs):
+        warnings.warn(

Review Comment:
   this is just a kind of warning, but please let me know  I should remove execute and execute_complete from `DatabricksRunNowDeferrableOperator`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org