[incubator-hugegraph-toolchain] branch master updated: refact: show detail info when parse line meet error (#325)

[ji...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hugegraph-toolchain.git


The following commit(s) were added to refs/heads/master by this push:
     new 6374d5f0 refact: show detail info when parse line meet error (#325)
6374d5f0 is described below

commit 6374d5f0b53d9577b1dc826c81dc90636ecb0807
Author: Shea <35...@qq.com>
AuthorDate: Wed Nov 2 00:19:54 2022 +0800

    refact: show detail info when parse line meet error (#325)
    
    * fix: Line check argument show detail info
    
    Co-authored-by: imbajin <ji...@apache.org>
---
 .../main/java/com/baidu/hugegraph/loader/reader/line/Line.java    | 8 ++++++--
 .../test/java/com/baidu/hugegraph/loader/test/unit/LineTest.java  | 3 +++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java b/hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java
index 8a656219..b3373796 100644
--- a/hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java
+++ b/hugegraph-loader/src/main/java/com/baidu/hugegraph/loader/reader/line/Line.java
@@ -20,6 +20,7 @@
 package com.baidu.hugegraph.loader.reader.line;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Set;
 
@@ -36,8 +37,11 @@ public final class Line {
         E.checkArgumentNotNull(rawLine, "The rawLine can't be null");
         E.checkArgumentNotNull(names, "The names can't be null");
         E.checkArgumentNotNull(values, "The values can't be null");
-        E.checkArgument(names.length == values.length,
-                        "The length of names %s should be same as values %s");
+        if (names.length != values.length) {
+            E.checkArgument(names.length == values.length,
+                            "The length of names %s should be same as values %s",
+                            Arrays.toString(names), Arrays.toString(values));
+        }
         this.rawLine = rawLine;
         this.names = names;
         this.values = values;
diff --git a/hugegraph-loader/src/test/java/com/baidu/hugegraph/loader/test/unit/LineTest.java b/hugegraph-loader/src/test/java/com/baidu/hugegraph/loader/test/unit/LineTest.java
index 93bac23c..32ea04b0 100644
--- a/hugegraph-loader/src/test/java/com/baidu/hugegraph/loader/test/unit/LineTest.java
+++ b/hugegraph-loader/src/test/java/com/baidu/hugegraph/loader/test/unit/LineTest.java
@@ -38,6 +38,9 @@ public class LineTest {
         Assert.assertThrows(IllegalArgumentException.class, () -> {
             new Line("1,marko", new String[]{"id", "name"}, null);
         });
+        Assert.assertThrows(IllegalArgumentException.class, () -> {
+            new Line("1,marko", new String[]{"id", "name"}, new Object[]{1});
+        });
     }
 
     @Test