You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/10 13:42:33 UTC

[GitHub] [hudi] slfan1989 opened a new pull request, #6909: HUDI-5002. Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

slfan1989 opened a new pull request, #6909:
URL: https://github.com/apache/hudi/pull/6909

   ### Change Logs
   
   JIRA: HUDI-5002. Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.
   
   When I read the code, I found that SparkHoodieHBaseIndex#generateStatement uses Hbase's deprecated method(setMaxVersion), I replaced it with new method.
   
   ![image](https://user-images.githubusercontent.com/55643692/194879918-04d4e531-902c-4b0f-b9dc-d4b188f7a45c.png)
   
   ```
   private Get generateStatement(String key) throws IOException {
     return new Get(Bytes.toBytes(getHBaseKey(key))).setMaxVersions(1).addColumn(SYSTEM_COLUMN_FAMILY, COMMIT_TS_COLUMN)
         .addColumn(SYSTEM_COLUMN_FAMILY, FILE_NAME_COLUMN).addColumn(SYSTEM_COLUMN_FAMILY, PARTITION_PATH_COLUMN);
   } 
   ```
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   **Risk level: none**
   
   Does not affect the original logic, use a recommend method to replace.
   
   _Choose one. If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #6909: [HUDI-5002] Remove deprecated API usage in SparkHoodieHBaseIndex#generateStatement

Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6909:
URL: https://github.com/apache/hudi/pull/6909


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1273357738

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0397ae90c5ee7e6e48873735172a07715fec083 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1274460026

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108",
       "triggerID" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0397ae90c5ee7e6e48873735172a07715fec083 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1274731888

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108",
       "triggerID" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0397ae90c5ee7e6e48873735172a07715fec083 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #6909: [HUDI-5002] Remove deprecated API usage in SparkHoodieHBaseIndex#generateStatement

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1277733995

   @xushiyan Thank you very much for helping to review the code!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #6909: HUDI-5002. Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1273334831

   @xushiyan Can you help review this pr? Thank you very much!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1273638451

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108",
       "triggerID" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0397ae90c5ee7e6e48873735172a07715fec083 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1273367220

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108",
       "triggerID" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0397ae90c5ee7e6e48873735172a07715fec083 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12108) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1276030543

   @codope Can you help review this pr? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6909: [HUDI-5002] Improve SparkHoodieHBaseIndex#generateStatement With Hbase Recommend Method.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6909:
URL: https://github.com/apache/hudi/pull/6909#issuecomment-1274453575

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a0397ae90c5ee7e6e48873735172a07715fec083",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a0397ae90c5ee7e6e48873735172a07715fec083 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org