[jira] [Commented] (AMBARI-21951) Last Run Service Check for SPARK Picks up SPARK2

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-21951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165466#comment-16165466 ] 

Hadoop QA commented on AMBARI-21951:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12886930/AMBARI-21951.patch
  against trunk revision .

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12215//console

This message is automatically generated.

> Last Run Service Check for SPARK Picks up SPARK2
> ------------------------------------------------
>
>                 Key: AMBARI-21951
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21951
>             Project: Ambari
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>            Priority: Critical
>             Fix For: 2.6.0
>
>         Attachments: AMBARI-21951.patch
>
>
> STR:
> - Install a cluster with Spark and Spark2
> - Remove Spark2
> - Change a Spark configuration
> - Run the Spark Service check
> - Attempt to perform an upgrade
> The upgrade pre-checks will stop you saying something like: 
> {code}
> 02 Aug 2017 10:17:23,701  INFO [ambari-client-thread-28] ServiceCheckValidityCheck:149 - Service SPARK latest config change is 08-02-2017 09:45:16, latest service check executed at 12-31-1969 03:59:59
> {code}
> The start time suggests a value of -1 in my cluster. The problem is that I aborted my SPARK2 service check and then removed the service. However, the pre-check seems to be matching on the name an incorrectly detecting the old SPARK2 check as the one for SPARK:
> {code}
>       boolean serviceCheckWasExecuted = false;
>       for (HostRoleCommandEntity command : latestTimestamps.values()) {
>         if (null !=  command.getCommandDetail() && command.getCommandDetail().contains(serviceName)) {
> {code}
> Because {{contains()}} is finding {{SPARK}} in {{SPARK2_SERVICE_CHECK}}, it's incorrectly picking up the wrong values...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)