You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2011/11/17 20:57:51 UTC
[jira] [Created] (MAPREDUCE-3424) MR-2415 cleanup
MR-2415 cleanup
---------------
Key: MAPREDUCE-3424
URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: tasktracker
Affects Versions: 0.20.205.0
Reporter: Eli Collins
Priority: Minor
Attachments: mapreduce-3424-1.patch
MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3424) Some LinuxTaskController cleanup
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated MAPREDUCE-3424:
----------------------------------
Fix Version/s: 1.1.0
> Some LinuxTaskController cleanup
> --------------------------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 1.1.0
>
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3424) MR-2415 cleanup
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated MAPREDUCE-3424:
-----------------------------------
Attachment: mapreduce-3424-3.patch
Updated patch attached. Minor update on the last one. I ran the tt test as well as the full suite and ran some jobs on 3 nodes w the the ltc enabled. test-patch results comming.
> MR-2415 cleanup
> ---------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3424) MR-2415 cleanup
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated MAPREDUCE-3424:
-----------------------------------
Attachment: mapreduce-3424-1.patch
Patch attached.
> MR-2415 cleanup
> ---------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3424) MR-2415 cleanup
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153970#comment-13153970 ]
Todd Lipcon commented on MAPREDUCE-3424:
----------------------------------------
Looks good. Did you run MR unit tests and the task-controller tests locally?
> MR-2415 cleanup
> ---------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3424) Some LinuxTaskController cleanup
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated MAPREDUCE-3424:
-----------------------------------
Summary: Some LinuxTaskController cleanup (was: MR-2415 cleanup)
> Some LinuxTaskController cleanup
> --------------------------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-3424) MR-2415 cleanup
Posted by "Eli Collins (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins reassigned MAPREDUCE-3424:
--------------------------------------
Assignee: Eli Collins
> MR-2415 cleanup
> ---------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-3424) Some LinuxTaskController cleanup
Posted by "Eli Collins (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved MAPREDUCE-3424.
------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Thanks Todd. I've committed this.
> Some LinuxTaskController cleanup
> --------------------------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3424) Some LinuxTaskController
cleanup
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155342#comment-13155342 ]
Todd Lipcon commented on MAPREDUCE-3424:
----------------------------------------
+1. Looks good.
> Some LinuxTaskController cleanup
> --------------------------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-3424) Some LinuxTaskController
cleanup
Posted by "Eli Collins (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154023#comment-13154023 ]
Eli Collins commented on MAPREDUCE-3424:
----------------------------------------
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
[exec]
{noformat}
The findbugs warning came from a previous change (see them w/ a null patch). Existing tests suffice since this is cleanup.
> Some LinuxTaskController cleanup
> --------------------------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-3424) MR-2415 cleanup
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated MAPREDUCE-3424:
-----------------------------------
Attachment: mapreduce-3424-2.patch
Updated patch attached. More cleanup. Also:
* Removes the reference to mapred.local.dir in task-controller.cfg from the cluster setup docs since it's no longer used
* This also removes the call to TaskController#setup in TT#initialize, this is already called by the constructor. For the DefaultTaskController we dont' need to reset the local storate and allocator refs as they haven't changed, and for the LTC we don't need to do the basic perms check on each init.
> MR-2415 cleanup
> ---------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira