[jira] Commented: (BEEHIVE-1118) form bean validations are not following the order

["Andrew McCulloch (JIRA)" <de...@beehive.apache.org>]

    [ http://issues.apache.org/jira/browse/BEEHIVE-1118?page=comments#action_12419343 ] 

Andrew McCulloch commented on BEEHIVE-1118:
-------------------------------------------

I attached a patch for this issue.  It is a pretty simple fix (most of my changes are new tests).  There are 3 testRecorder tests that changed as well as 3 new test cases in the compiler bvts.  the actual code change is 1 line (changing a HashMap to a LinkedHashMap to maintain insertion order).

Please review it and let me know if it is helpful.

> form bean validations are not following the order
> -------------------------------------------------
>
>          Key: BEEHIVE-1118
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-1118
>      Project: Beehive
>         Type: Bug

>   Components: NetUI
>     Versions: 1.0.1
>     Reporter: Srinivas Surapaneni
>  Attachments: BEEHIVE-1118.patch
>
> I had a form bean with annotation based validations for each getter method in the form bean
> When the validations are done, it is not following the order of the attributes
> Ex:  I had date, serialNumber, sampleValue.  When the validations are done, it is always calling the validations on sampleValue followed by date and serial Number
> Is there any way to specify the order of how the validations are being called
> Here is the sampe form
> @Jpf.FormBean(messageBundle="errors")
> public class SampleForm implements Validatable, Serializable {
> 	String date;
> 	String serialNumber;
> 	String sampleValue;
> 	
> 	@Jpf.ValidatableProperty(validateRequired=@Jpf.ValidateRequired(messageKey="000.error", messageArgs={@Jpf.MessageArg(arg="${bundle.dstbundle.date}", position=0)}), validateDate=@Jpf.ValidateDate(messageKey="001.error", messageArgs={@Jpf.MessageArg(arg="${bundle.dstbundle.date}", position=0)}, pattern="mm/dd/yyyy", strict=false))
> 	public String getDate() {
> 		return date;
> 	}
> 	public void setDate(String date) {
> 		this.date = date;
> 	}
> 	
> 	@Jpf.ValidatableProperty(validateRequired=@Jpf.ValidateRequired(messageArgs={@Jpf.MessageArg(arg="${bundle.dstbundle.serial}", position=0)}))
> 	public String getSerialNumber() {
> 		return serialNumber;
> 	}
> 	public void setSerialNumber(String serialNumber) {
> 		this.serialNumber = serialNumber;
> 	}
> 	public void validate(ActionMapping mapping, HttpServletRequest request, ActionMessages errors) {
> 		System.out.println("In the validate method" + errors.size());
> 		
> 	}
> 	@Jpf.ValidatableProperty(validateRequired=@Jpf.ValidateRequired(messageKey="000.error", messageArgs={@Jpf.MessageArg(arg="${bundle.dstbundle.sample}", position=0)}), validateMinLength=@Jpf.ValidateMinLength(messageKey="003.error", messageArgs={@Jpf.MessageArg(arg="${bundle.dstbundle.sample}", position=0)}, chars=4))
> 	public String getSampleValue() {
> 		return sampleValue;
> 	}
> 	public void setSampleValue(String sampleValue) {
> 		this.sampleValue = sampleValue;
> 	}
> 	
> 	
> 	
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira