You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by joewitt <gi...@git.apache.org> on 2016/07/14 05:29:25 UTC
[GitHub] nifi pull request #647: NIFI-1157 NIFI-1307 Resolve deprecated classes and m...
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/647
NIFI-1157 NIFI-1307 Resolve deprecated classes and methods
The PR is three commits that build on eachother. I kept them seperate because each is a significant but full step toward the goals of the JIRA NIFI-1307 and NIFI-1157. NIFI-1307 removes the deprecation marking for FlowFile.getId() which is pretty deeply relied upon by the framework to include how data is serialized/deserialized. NIFI-1157 then takes that NIFI-1307 basis and first resolves all deprecation markings in nifi-api and deals with all ripple effects throughout the codebase. Then finally a search was conducted across the entire codebase to find deprecated classes and methods in our code and remove them and solve any references to them. There are still some deprecated bits but they are left intentionally (as in the case of legacy nifi KDF for example) or are 3rd party libraries we use which we presently utilize deprecated classes for and were not part of the scope of this effort.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-1307
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #647
----
commit 3f4c3bd1ccc544edac9b6f4937519bfdab32ba44
Author: joewitt <jo...@apache.org>
Date: 2016-07-13T22:42:10Z
NIFI-1307 removed deprecation indication for getId and provided better API documentation
commit a2ab663a53150169a754012479df002aa9e43a89
Author: joewitt <jo...@apache.org>
Date: 2016-07-13T23:36:03Z
NIFI-1157 resolved deprecated nifi-api items and ripple effects
commit 9ad505af68c3cb3cf6a316ed6aa6ba4ba991610b
Author: joewitt <jo...@apache.org>
Date: 2016-07-14T04:51:04Z
NIFI-1157 searched for and resolved all remaining references to deprecated items that were clearly addressable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #647: NIFI-1157 NIFI-1307 Resolve deprecated classes and methods
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/647
@joewitt the code changes look good. Was able to build and verify that all still compiles and that all unit tests still pass. Tested a lot of different scenarios that I could think of to ensure that application still functions as intended, and everything looks good! +1 merged to master! Thanks for going through all of this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #647: NIFI-1157 NIFI-1307 Resolve deprecated classes and m...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt closed the pull request at:
https://github.com/apache/nifi/pull/647
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---