You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/19 16:12:26 UTC
[GitHub] [ignite-3] vldpyatkov opened a new pull request, #1458: IGNITE-18050 Possible phantom reads during sorted index scan
vldpyatkov opened a new pull request, #1458:
URL: https://github.com/apache/ignite-3/pull/1458
https://issues.apache.org/jira/browse/IGNITE-18050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1458: IGNITE-18050 Possible phantom reads during sorted index scan
Posted by GitBox <gi...@apache.org>.
vldpyatkov commented on code in PR #1458:
URL: https://github.com/apache/ignite-3/pull/1458#discussion_r1053400387
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java:
##########
@@ -95,39 +96,54 @@ public CompletableFuture<Void> locksForLookup(UUID txId, BinaryRow tableRow) {
* @return A future representing a result.
Review Comment:
Added description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #1458: IGNITE-18050 Possible phantom reads during sorted index scan
Posted by GitBox <gi...@apache.org>.
vldpyatkov commented on code in PR #1458:
URL: https://github.com/apache/ignite-3/pull/1458#discussion_r1053389011
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -427,6 +428,55 @@ public void pureTableScan(Function<InternalTransaction, CompletableFuture<Intege
assertEquals(ROW_IDS.size() + txOpFut.get(), scanAllRows(pub).size());
}
+ @Test
+ public void testTwiceScanInTransaction() throws Exception {
+ TableImpl table = getOrCreateTable();
+
+ InternalTable internalTable = table.internalTable();
+
+ KeyValueView kvView = table.keyValueView();
+
+ UUID soredIndexId = getSortedIndexId();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #1458: IGNITE-18050 Possible phantom reads during sorted index scan
Posted by GitBox <gi...@apache.org>.
denis-chudov commented on code in PR #1458:
URL: https://github.com/apache/ignite-3/pull/1458#discussion_r1053375514
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/SortedIndexLocker.java:
##########
@@ -95,39 +96,54 @@ public CompletableFuture<Void> locksForLookup(UUID txId, BinaryRow tableRow) {
* @return A future representing a result.
Review Comment:
there is no description, what is the result. Same for `acquireLockNextKey`.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItTableScanTest.java:
##########
@@ -427,6 +428,55 @@ public void pureTableScan(Function<InternalTransaction, CompletableFuture<Intege
assertEquals(ROW_IDS.size() + txOpFut.get(), scanAllRows(pub).size());
}
+ @Test
+ public void testTwiceScanInTransaction() throws Exception {
+ TableImpl table = getOrCreateTable();
+
+ InternalTable internalTable = table.internalTable();
+
+ KeyValueView kvView = table.keyValueView();
+
+ UUID soredIndexId = getSortedIndexId();
Review Comment:
typo: `sortedIndexId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] vldpyatkov merged pull request #1458: IGNITE-18050 Possible phantom reads during sorted index scan
Posted by GitBox <gi...@apache.org>.
vldpyatkov merged PR #1458:
URL: https://github.com/apache/ignite-3/pull/1458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org