You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by GitBox <gi...@apache.org> on 2020/06/09 15:47:07 UTC
[GitHub] [ambari] rickyma opened a new pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
rickyma opened a new pull request #3201:
URL: https://github.com/apache/ambari/pull/3201
## What changes were proposed in this pull request?
Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
## How was this patch tested?
Compile and test in our development environment.
@hapylestat : The pull request for branch-2.7 is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] rickyma commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
rickyma commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646400286
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] rickyma commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
rickyma commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-645878972
@hapylestat Hey, any progress on this? I see all builds of my three pull requests are failed. Can we run it again? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646556760
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646556650
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-641922763
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] rickyma commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
rickyma commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646404418
@hapylestat The previous CI link was 404. So I could not see the details. But I've changed the import order based on my thought. Please check it again to see if it is okay now. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] rickyma commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
rickyma commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-651255078
@hapylestat It seems ok now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-641943899
@rickyma sorry for confusing you, it is a manual way to trigger CI here if it was not triggered automatically
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat removed a comment on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat removed a comment on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646556650
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-641943535
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] rickyma removed a comment on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
rickyma removed a comment on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646400286
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] rickyma commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
rickyma commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-641930997
@hapylestat I've already retested it, and it worked fine in our environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ambari] hapylestat commented on pull request #3201: AMBARI-25517. Should not use '!=' to compare 'Long hostId' in HostStateEntity, which could lead to unforeseen problems
Posted by GitBox <gi...@apache.org>.
hapylestat commented on pull request #3201:
URL: https://github.com/apache/ambari/pull/3201#issuecomment-646244868
@rickyma please follow the failed test suit by using details and check. In current situation it fail coz your patch did not pass style check. Please fix the import order
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org