[GitHub] [flink] tillrohrmann edited a comment on issue #8303: [FLINK-12343]add file replication config for yarn configuration

[GitBox <gi...@apache.org>]

tillrohrmann edited a comment on issue #8303: [FLINK-12343]add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#issuecomment-487879423
 
 
   Sorry for having to push back here. The current implementation should not work because `FileSystem#setReplication` only works on existing files. Thus, this PR should effectively be a no-op. If you move the `setReplication` call after the `copyFromLocalFile`, then it only changes the replication afterwards. 
   
   The underlying problem imo is that we have not agreed on a proper way to solve this problem which should be part of the JIRA discussion. By first agreeing on the overall approach we save a lot of time reviewing PRs which don't work. I hope that this will soon be properly reflected in the contribution guidelines @rmetzger.
   
   One solution could be to set the `dfs.replication` value in the Hadoop configuration according to the introduced config option. We definitely need tests to validate the solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services