You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "László Bodor (Jira)" <ji...@apache.org> on 2024/06/06 12:43:00 UTC
[jira] [Commented] (HIVE-28305) ProfileServlet: add html to output formats and prepare for profiler 3.0
[ https://issues.apache.org/jira/browse/HIVE-28305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852762#comment-17852762 ]
László Bodor commented on HIVE-28305:
-------------------------------------
merged to master, thanks [~dkuzmenko], [~ayushtkn], [~kokila19] for the reviews!
> ProfileServlet: add html to output formats and prepare for profiler 3.0
> -----------------------------------------------------------------------
>
> Key: HIVE-28305
> URL: https://issues.apache.org/jira/browse/HIVE-28305
> Project: Hive
> Issue Type: Bug
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.1.0
>
> Attachments: async-prof-pid-21327-cpu-2.html
>
>
> {code}
> query-executor <14>1 2024-06-05T12:12:59.188Z query-executor-0-0 query-executor 1 8a250c32-ca6d-4fb8-a5a7-00569a3141d3 [mdc@18060 class="util.ProcessUtils" level="INFO" thread="llap-web-49"] Running command async: [/async-profiler/async-profiler-2.9-linux-x64/profiler.sh, -e, cpu, -d, 15, -o, svg, -f, /tmp/prof-output/async-prof-pid-1-cpu-1.svg, 1]
> query-executor [WARN] Unknown argument: svg
> query-executor [ERROR] SVG format is obsolete, use .html for FlameGraph
> {code}
> https://github.com/apache/hive/blob/529fd45c6556c2e9e7f647297234b97c4060a031/common/src/java/org/apache/hive/http/ProfileServlet.java#L137-L145
> in recent versions of async-profiler, SVG is not accepted at all, and unfortunately, HTML cannot even be chosen due to a strict parse:
> https://github.com/apache/hive/blob/529fd45c6556c2e9e7f647297234b97c4060a031/common/src/java/org/apache/hive/http/ProfileServlet.java#L346
> for backward compatibility, SVG is fine, but HTML should be added to the enum
--
This message was sent by Atlassian Jira
(v8.20.10#820010)