You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by ra...@apache.org on 2014/09/12 00:19:23 UTC
[18/41] git commit: FALCON-649 Remove unnecessary validation for
Instance start time in FalconCLI. Contributed by Balu Vellanki
FALCON-649 Remove unnecessary validation for Instance start time in FalconCLI. Contributed by Balu Vellanki
Project: http://git-wip-us.apache.org/repos/asf/incubator-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-falcon/commit/8f30ae0e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-falcon/tree/8f30ae0e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-falcon/diff/8f30ae0e
Branch: refs/heads/FALCON-585
Commit: 8f30ae0e0a47288e1a924ac315c377103a883927
Parents: 0bd9c77
Author: Venkatesh Seetharam <ve...@apache.org>
Authored: Tue Sep 2 13:11:03 2014 -0700
Committer: Venkatesh Seetharam <ve...@apache.org>
Committed: Tue Sep 2 13:11:03 2014 -0700
----------------------------------------------------------------------
CHANGES.txt | 3 +++
client/src/main/java/org/apache/falcon/cli/FalconCLI.java | 10 ++--------
2 files changed, 5 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-falcon/blob/8f30ae0e/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index ca12d59..45f0ac3 100755
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -72,6 +72,9 @@ Trunk (Unreleased)
OPTIMIZATIONS
BUG FIXES
+ FALCON-649 Remove unnecessary validation for Instance start time in
+ FalconCLI (Balu Vellanki via Venkatesh Seetharam)
+
FALCON-579 Lineage breaks if feed.xml doesn't have the date pattern in
feed path location (Sowmya Ramesh via Venkatesh Seetharam)
http://git-wip-us.apache.org/repos/asf/incubator-falcon/blob/8f30ae0e/client/src/main/java/org/apache/falcon/cli/FalconCLI.java
----------------------------------------------------------------------
diff --git a/client/src/main/java/org/apache/falcon/cli/FalconCLI.java b/client/src/main/java/org/apache/falcon/cli/FalconCLI.java
index f5b30f0..a42da13 100644
--- a/client/src/main/java/org/apache/falcon/cli/FalconCLI.java
+++ b/client/src/main/java/org/apache/falcon/cli/FalconCLI.java
@@ -235,7 +235,7 @@ public class FalconCLI {
colo = getColo(colo);
String instanceAction = "instance";
- validateInstanceCommands(optionsList, entity, type, start, colo);
+ validateInstanceCommands(optionsList, entity, type, colo);
if (optionsList.contains(RUNNING_OPT)) {
@@ -290,7 +290,7 @@ public class FalconCLI {
private void validateInstanceCommands(Set<String> optionsList,
String entity, String type,
- String start, String colo) throws FalconCLIException {
+ String colo) throws FalconCLIException {
if (StringUtils.isEmpty(entity)) {
throw new FalconCLIException("Missing argument: name");
@@ -304,12 +304,6 @@ public class FalconCLI {
throw new FalconCLIException("Missing argument: colo");
}
- if (!optionsList.contains(RUNNING_OPT)) {
- if (StringUtils.isEmpty(start)) {
- throw new FalconCLIException("Missing argument: start");
- }
- }
-
if (optionsList.contains(CLUSTERS_OPT)) {
if (optionsList.contains(RUNNING_OPT)
|| optionsList.contains(LOG_OPT)