You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 16:13:10 UTC

[GitHub] [airflow] dstandish edited a comment on pull request #15104: Get connection URI with AWS Secrets Manager

dstandish edited a comment on pull request #15104:
URL: https://github.com/apache/airflow/pull/15104#issuecomment-812596462


   may i suggest using `_create_connection` function here
   https://github.com/apache/airflow/pull/15013/files#diff-258df8f49a97540963b45ae4ac0e0f71720101134f73b2981b8ab3dd1a4cf5fcR24
   
   i think we ultimately ought to provide a shared way of parsing creds from json and this function could be a good starting point.  
   
   PR #15013 is doing the same thing for Vault and is re-using that function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org